Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] Rename Dev Overlay to Dev Toolbar #5541

Merged
merged 12 commits into from
Dec 5, 2023
Merged

[i18nIgnore] Rename Dev Overlay to Dev Toolbar #5541

merged 12 commits into from
Dec 5, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 1, 2023

Description (required)

Renames Dev Overlay to Dev Toolbar as well as plugins to apps.

Related issues & labels (optional)

For Astro 4

For Astro version: 4.x. See astro PR #9271.

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 5, 2023 4:47pm

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. 4.0 merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Dec 2, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add in some changes based on PR #5516 that adds new components and changes other ones. 😅

Please verify the changes here, and there's also a change that I have to edit the file directly for because I can't suggest in that area. So, I'll be adding content from the other PR in at line 357 (astro-dev-toolbar-icon and the section on Icons) directly.

vercel.json Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Note to self: if all my suggestions are fine as-is, then I approve this PR and it's ready for 4.0 release!

@sarah11918 sarah11918 added the Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! label Dec 3, 2023
@sarah11918 sarah11918 removed the Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! label Dec 4, 2023
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 4, 2023
src/i18n/zh-cn/nav.ts Outdated Show resolved Hide resolved
@sarah11918
Copy link
Member

Note to self: have asked for translator reviews for the nav/integration-reference files.

Otherwise, the English content is good to go!

src/i18n/hi/nav.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit the text for toolbar API in french

src/i18n/fr/nav.ts Outdated Show resolved Hide resolved
src/i18n/ko/nav.ts Outdated Show resolved Hide resolved
src/i18n/es/nav.ts Outdated Show resolved Hide resolved
Co-authored-by: Thomas Bnt <[email protected]>
Co-authored-by: Atharva Pise <[email protected]>
Co-authored-by: Lucid Jeon <[email protected]>
Co-authored-by: Genteure <[email protected]>
Co-authored-by: Kevin Zuniga Cuellar <[email protected]>
src/i18n/fr/nav.ts Outdated Show resolved Hide resolved
@sarah11918 sarah11918 changed the title Rename Dev Overlay to Dev Toolbar [i18nIgnore] Rename Dev Overlay to Dev Toolbar Dec 4, 2023
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 4, 2023
Copy link
Contributor

@Waxer59 Waxer59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retranslating a text into Spanish translations

src/content/docs/es/reference/integrations-reference.mdx Outdated Show resolved Hide resolved
src/i18n/zh-cn/nav.ts Outdated Show resolved Hide resolved
Co-authored-by: Genteure <[email protected]>
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@sarah11918 sarah11918 merged commit 896b8c9 into main Dec 5, 2023
5 of 6 checks passed
@sarah11918 sarah11918 deleted the dev-toolbar branch December 5, 2023 16:34
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Erika <[email protected]>
Co-authored-by: Genteure <[email protected]>
Co-authored-by: Thomas Bnt <[email protected]>
Co-authored-by: Elian <[email protected]>
Co-authored-by: Xiaoyue Lin <[email protected]>
Co-authored-by: Lucid Jeon <[email protected]>
Co-authored-by: Kevin Zuniga Cuellar <[email protected]>
Co-authored-by: Waxer59 <[email protected]>
Co-authored-by: Atharva Pise <[email protected]>
NinuzIBZ added a commit to NinuzIBZ/docs that referenced this pull request Feb 1, 2024
The file `nav.ts` has been updated to align with the English language documentation based on this commits withastro#4876 , withastro#5183 , withastro#5213 , withastro#5271 , withastro#5187 , withastro#4667 , withastro#5541 , withastro#5605 , withastro#5499 , withastro#6470 , withastro#6620
@NinuzIBZ NinuzIBZ mentioned this pull request Feb 1, 2024
yanthomasdev added a commit that referenced this pull request Feb 5, 2024
The file `nav.ts` has been updated to align with the English language documentation based on this commits #4876 , #5183 , #5213 , #5271 , #5187 , #4667 , #5541 , #5605 , #5499 , #6470 , #6620

Co-authored-by: Yan Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.