-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18nIgnore] Rename Dev Overlay to Dev Toolbar #5541
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to add in some changes based on PR #5516 that adds new components and changes other ones. 😅
Please verify the changes here, and there's also a change that I have to edit the file directly for because I can't suggest in that area. So, I'll be adding content from the other PR in at line 357 (astro-dev-toolbar-icon
and the section on Icons) directly.
Note to self: if all my suggestions are fine as-is, then I approve this PR and it's ready for 4.0 release! |
Note to self: have asked for translator reviews for the nav/integration-reference files. Otherwise, the English content is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit the text for toolbar API in french
Co-authored-by: Thomas Bnt <[email protected]> Co-authored-by: Atharva Pise <[email protected]> Co-authored-by: Lucid Jeon <[email protected]> Co-authored-by: Genteure <[email protected]>
Co-authored-by: Kevin Zuniga Cuellar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retranslating a text into Spanish translations
Co-authored-by: Waxer59 <[email protected]>
Co-authored-by: Genteure <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Genteure <[email protected]> Co-authored-by: Thomas Bnt <[email protected]> Co-authored-by: Elian <[email protected]> Co-authored-by: Xiaoyue Lin <[email protected]> Co-authored-by: Lucid Jeon <[email protected]> Co-authored-by: Kevin Zuniga Cuellar <[email protected]> Co-authored-by: Waxer59 <[email protected]> Co-authored-by: Atharva Pise <[email protected]>
The file `nav.ts` has been updated to align with the English language documentation based on this commits withastro#4876 , withastro#5183 , withastro#5213 , withastro#5271 , withastro#5187 , withastro#4667 , withastro#5541 , withastro#5605 , withastro#5499 , withastro#6470 , withastro#6620
Description (required)
Renames Dev Overlay to Dev Toolbar as well as plugins to apps.
Related issues & labels (optional)
For Astro 4
For Astro version:
4.x
. See astro PR #9271.