Stop recursive double setting of default options (#5456)

There is no need to call `setDefaultOptions` on the `childViewController` while iterating the `childViewControllers` as those will be passed recursively as `rootViewController` anyway and thus calling `setDefaultOptions` in the nested recursive call.
wix · Sep 5, 2019 · d5c92b1 · d5c92b1
1 parent b048581
commit d5c92b1
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/ios/RNNDefaultOptionsHelper.m b/lib/ios/RNNDefaultOptionsHelper.m
@@ -3,14 +3,11 @@
 @implementation RNNDefaultOptionsHelper
 
 + (void)recrusivelySetDefaultOptions:(RNNNavigationOptions *)defaultOptions onRootViewController:(UIViewController *)rootViewController {
-	if ([rootViewController conformsToProtocol:@protocol(RNNLayoutProtocol)])
+	if ([rootViewController conformsToProtocol:@protocol(RNNLayoutProtocol)]) {
 		[((UIViewController<RNNLayoutProtocol> *)rootViewController) setDefaultOptions:defaultOptions];
+	}
 
 	for (UIViewController<RNNLayoutProtocol>* childViewController in rootViewController.childViewControllers) {
-		if ([childViewController conformsToProtocol:@protocol(RNNLayoutProtocol)]) {
-			[childViewController setDefaultOptions:defaultOptions];
-		}
-
 		[self recrusivelySetDefaultOptions:defaultOptions onRootViewController:childViewController];
 	}
 }