Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload while modal is showing, modal leaks #877

Closed
DanielZlotin opened this issue Mar 19, 2017 · 3 comments
Closed

reload while modal is showing, modal leaks #877

DanielZlotin opened this issue Mar 19, 2017 · 3 comments
Assignees
@DanielZlotin
Labels
platform: iOS
Milestone
2.x.x Complete Re...

Comments

@DanielZlotin
Copy link
Contributor

DanielZlotin commented Mar 19, 2017 •
edited
Loading

see #878
Maybe wix/Detox#23 will help.

Currently fixed by manually unsubscribing from NotificationCenter events on JSReload and nullifying the view.
@DanielZlotin DanielZlotin added this to the 2.0.0 milestone Mar 19, 2017
@DanielZlotin DanielZlotin self-assigned this Mar 19, 2017
@DanielZlotin DanielZlotin changed the title reload bug reload while modal is showing Mar 19, 2017
@DanielZlotin DanielZlotin changed the title reload while modal is showing reload while modal is showing, modal leaks Mar 20, 2017
DanielZlotin added a commit that referenced this issue Mar 20, 2017
@DanielZlotin
fix for #877,878,880
3b63f64
@trleithoff
Copy link

I am having this same issue in my react native app but I am not understanding how to solve it. How do you "manually unsubscribe from NotificationCenter events on JSReload" thus nullifying the view?? Can someone please give a code example of this because I'm having trouble finding anything on the web!

@guyca
Copy link
Collaborator

guyca commented Mar 29, 2018

@trleithoff
This issue is relates to v2 and has been fixed in the last week. What version are you using?

@trleithoff
Copy link

Here are our versions:

"react": "16.3.0-alpha.1",
"react-native": "0.54.2",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielZlotin DanielZlotin

Labels
platform: iOS
Projects
None yet
Milestone
2.x.x Complete Rewrite (full feature ...
Development

No branches or pull requests
3 participants
@trleithoff @DanielZlotin @guyca