-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github Container Repository #156
Conversation
Signed-off-by: Flavio Fernandes <[email protected]>
@thom311 / @SalDaniele PTAL |
LGTM Thanks @flavio-fernandes! |
Could you please elaborate on the background of this patch? Why do we expect the repo to be moving? |
Hi @thom311, |
@flavio-fernandes Do I need to install "secrets.GITHUB_TOKEN" somehow? |
For my fork I had to add a new Personal access token to my Github:
Copy the token and add it as a secret to the repo as we did with quay credentials in the past (Will push a follow-up PR because it seems Github does not like secrets starting with "GITHUB") |
Actually disregard, I think this secret exists by default. #158 should do the trick |
TY both! |
I can now |
Update repo to use the new image hosted via ghcr.io. Follow up to wizhaoredhat#156 Signed-off-by: Salvatore Daniele <[email protected]>
In anticipation to this repo moving... ;)