Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github Container Repository #156

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

flavio-fernandes
Copy link
Contributor

In anticipation to this repo moving... ;)

Signed-off-by: Flavio Fernandes <[email protected]>
@wizhaoredhat
Copy link
Owner

@thom311 / @SalDaniele PTAL

@SalDaniele
Copy link
Collaborator

LGTM Thanks @flavio-fernandes!

@thom311
Copy link
Collaborator

thom311 commented Oct 18, 2024

Could you please elaborate on the background of this patch? Why do we expect the repo to be moving?

@flavio-fernandes
Copy link
Contributor Author

Could you please elaborate on the background of this patch? Why do we expect the repo to be moving?

Hi @thom311,
I might be mistaken here, so please feel free to correct me, but I was under the impression that traffic-flow-tests would eventually become part of the ovn-kubernetes umbrella, as the project transitions into its own organization [ 1 ]. While this change is still a bit down the road, my current goal is to integrate this fantastic suite as a lane in the ovn-kubernetes pull requests. This way, we can ensure no regressions occur concerning the expected traffic flows that should always function properly [ 2 ].

@SalDaniele SalDaniele merged commit 3670104 into wizhaoredhat:main Oct 18, 2024
3 checks passed
@wizhaoredhat
Copy link
Owner

@flavio-fernandes Do I need to install "secrets.GITHUB_TOKEN" somehow?

@SalDaniele
Copy link
Collaborator

For my fork I had to add a new Personal access token to my Github:

  • Settings
  • Developer Settings
  • Personal Access Tokens (opted for classic)

Copy the token and add it as a secret to the repo as we did with quay credentials in the past (Will push a follow-up PR because it seems Github does not like secrets starting with "GITHUB")

@SalDaniele
Copy link
Collaborator

Actually disregard, I think this secret exists by default.

#158 should do the trick

@flavio-fernandes flavio-fernandes deleted the use_ghcr.io branch October 18, 2024 17:07
@flavio-fernandes
Copy link
Contributor Author

Actually disregard, I think this secret exists by default.

#158 should do the trick

TY both!

@flavio-fernandes
Copy link
Contributor Author

I can now docker pull ghcr.io/wizhaoredhat/ocp-traffic-flow-tests:pr_test woot. ;)

SalDaniele added a commit to SalDaniele/ocp-traffic-flow-tests that referenced this pull request Oct 18, 2024
Update repo to use the new image hosted via ghcr.io.

Follow up to wizhaoredhat#156

Signed-off-by: Salvatore Daniele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants