Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 99% coverage threshold flag for 3.10 in noxfile #593

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Drop 99% coverage threshold flag for 3.10 in noxfile #593

merged 2 commits into from
Apr 7, 2022

Conversation

FollowTheProcess
Copy link
Collaborator

This PR drops the flag in our Noxfile that would set the fail_under threshold to 99% on python 3.10. This was a hangover from when we were testing against 3.10.0-rc.2 in GHA and coverage was raising a few false positives.

Judging by recent runs this flag can be removed now.

See this comment for further details: #592 (comment)

@FollowTheProcess FollowTheProcess added the ci Issues relating to nox's CI pipeline label Apr 7, 2022
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@FollowTheProcess FollowTheProcess merged commit 4399ec5 into wntrblm:main Apr 7, 2022
@FollowTheProcess FollowTheProcess deleted the 3.10-coverage-threshold branch April 7, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues relating to nox's CI pipeline
Development

Successfully merging this pull request may close these issues.

2 participants