Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 99% coverage threshold flag for 3.10 in noxfile #593

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Drop 99% coverage threshold flag for 3.10 in noxfile #593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5168a81
Drop 99% coverage threshold flag for 3.10 in noxfile
FollowTheProcess Apr 7, 2022
a1641f0
Ooops, fix pre-commit failures
FollowTheProcess Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import os
import platform
import shutil
import sys

import nox

Expand Down Expand Up @@ -68,16 +67,9 @@ def cover(session):
if ON_WINDOWS_CI:
return

# 3.10 produces different coverage results for some reason
# see https://github.com/theacodes/nox/issues/478
fail_under = 100
py_version = sys.version_info
if py_version.major == 3 and py_version.minor == 10:
fail_under = 99

session.install("coverage[toml]")
session.run("coverage", "combine")
session.run("coverage", "report", f"--fail-under={fail_under}", "--show-missing")
session.run("coverage", "report", "--fail-under=100", "--show-missing")
session.run("coverage", "erase")


Expand Down