fix(rp2040): Fix CMP reg T1 #31
Conversation
|
Please be patient, one Day I'll learn how to PR only the relevant commits... |
src/instructions.spec.ts
Outdated
| await cpu.writeUint16(0x20000000, opcodeCMPregT1(r2, r0)); | ||
| await cpu.setRegisters({ r0: 0xb71b0000 }); | ||
| await cpu.setRegisters({ r2: 0x00b71b00 }); | ||
| await cpu.setRegisters({ xPSR: 0x61000000 }); |
There was a problem hiding this comment.
Instead of setting xPSR directly, let's set the specific flags (like we did in the "should execute add sp, r8 instruction and not update the flags" test case)
There was a problem hiding this comment.
Also, we can have a single call to setRegisters setting all the registers at once (instead of one call per register)
src/instructions.spec.ts
Outdated
| @@ -469,6 +469,19 @@ describe('Cortex-M0+ Instruction Set', () => { | |||
| expect(registers.V).toEqual(false); | |||
| }); | |||
|
|
|||
| it('should execute an `cmp r2, r0` instruction', async () => { | |||
There was a problem hiding this comment.
Let's make the test name more specific, like: "should execute an cmp r2, r0 instruction and not set any flags when r0=0xb71b0000 and r2=0x00b71b00"
if you need any help with that let me know |
src/instructions.spec.ts
Outdated
| @@ -469,6 +469,18 @@ describe('Cortex-M0+ Instruction Set', () => { | |||
| expect(registers.V).toEqual(false); | |||
| }); | |||
|
|
|||
| it('should execute an cmp r2, r0 instruction and not set any flags when r0=0xb71b0000 and r2=0x00b71b00', async () => { | |||
There was a problem hiding this comment.
Ok, one more small thing: please add backticks (`) around the instruction name, like in the other tests
found a specific test where CMPregT1 wrongly set the carry