This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Google Analytics - Support a GT tracking ID #7213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: 0 B Total Size: 893 kB ℹ️ View Unchanged
|
mikkamp
requested review from
a team and
tarhi-saad
and removed request for
a team
tarhi-saad
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Thank you, @mikkamp, for working on this PR! 🙌 I followed the testing instructions, and I believe I did so correctly:
- I created a new property in Google Analytics for my Jurassic Ninja testing site
- The following tag was created (a
G-tag):
- I retrieved the second tag (
GT-) from theTag detailspage:
- I added the Google tag in Google Analytics Integration Extension:
- I triggered some events in the
Cart&All Productsblocks, and the Browser Dev Tools > Network displayed some requests sent to Google Analytics:
- Lastly, I checked my Google Analytics account -> Reports -> Realtime:
Please let me know if there is anything I missed! If not, feel free to 🚢 it! 👍
|
Thanks for the review @tarhi-saad you followed those testing steps perfectly. Still find it a quirky way to create a GT-ID but those are the steps we were suggested. As for merging, I still see |
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Analytics Integration extension now supports GTAG tracking with ID's prefixed with both
G-andGT-. This PR changes the tracking code to load for both types of prefixes.Fixes woocommerce/woocommerce-google-analytics-integration#228
Other Checks
Testing
Automated Tests
User Facing Testing
https://region1.google-analytics.com/g/collect(region could vary)WooCommerce Visibility
Changelog