Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GA4 implementation for blocks within the extension #227

Closed
mikkamp opened this issue Sep 15, 2022 · 0 comments · Fixed by #269
Closed

Move GA4 implementation for blocks within the extension #227

mikkamp opened this issue Sep 15, 2022 · 0 comments · Fixed by #269
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@mikkamp
Copy link
Contributor

mikkamp commented Sep 15, 2022

User story

The WooCommerce Blocks extension has a separate implementation for supporting tracking events from Blocks, see: woocommerce/woocommerce-blocks#3953
This code is also present within WooCommerce core as part of the blocks package.

Now that this has matured, we shouldn't have to maintain the code for this in a separate location. So it's best to move this code within the Google Analytics Integration extension.

Potential blockers/points to take into consideration

Describe the solution you'd like

For all the Google Analytics tracking code to be maintained in the same extension

Technical

A good example to get references from is how the hooks are used with GLA to add additional tracking: https://github.com/woocommerce/google-listings-and-ads/blob/2.1.2/js/src/gtag-events/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant