Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WC Block Actions within the extension. #269

Merged
merged 25 commits into from
May 1, 2023
Merged

Move WC Block Actions within the extension. #269

merged 25 commits into from
May 1, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented May 1, 2023

Changes proposed in this Pull Request:

Closes #227

Changelog entry

Add - Create WordPress Hook Actions for Google Analytics
Dev - Implement Javascript Building

puntope and others added 25 commits March 23, 2023 18:02
@puntope
Implement JS Build (ES6) and JS Lint
23d9af4
@puntope
Add Jquery as a global and remove unnevesary lint exception
f61ea20
@puntope
Add missing prettier and remove uglify
da1284f
@puntope
Exclude eslintrc.js
67d7e89
@puntope
Remove unnecesary directives in eslintr file
ad25ad9
@puntope
Refactor admin load assets
f3e783b
@puntope
Make google_analytics_integration_product_data globally accesible
be57224
@puntope
Fix translation domain
108a856
@puntope
Change NAMESPACE for the actions hook
d30bce6
@puntope
Fix destructuring bug
890cee5
@puntope @eason9487
Update assets/js/src/actions.js
824ae0f 
Co-authored-by: Eason <[email protected]>
@puntope
Restore original implementation for get product id function
38214ee
@puntope
ES LInt
f2063fb
@puntope
PHPCS
12800af
@puntope
Add extra dependencies
450963e
@puntope
Remove eslint-import-resolver-webpack dependency
3b5ea43
@puntope
Update comments
f2689e1
@puntope
PHPCS
3a587d8
@puntope
Remove composer install from scripts
33e19c8
@puntope
Merge pull request #261 from woocommerce/feature/ga-actions
025214b 
Implement JS Build (ES6) and JS Lint
@puntope
Adding new actions
8229ed2
@puntope
Implement tracking using actions
567c4a5
@puntope
Ignore false positive semgrep warning
2841c7c
@puntope
Escape url for redirect
3546a0b
@puntope
Merge pull request #264 from woocommerce/wc-blocks-actions
6953bb2 
Add new actions for tracking
@puntope puntope self-assigned this May 1, 2023
@puntope puntope marked this pull request as ready for review May 1, 2023 08:01
@puntope puntope merged commit 0a0e43b into trunk May 1, 2023
@puntope puntope deleted the feature/analytics-wc-blocks branch May 1, 2023 08:01
@eason9487 eason9487 added the changelog: add A new feature, function, or functionality was added. label May 2, 2023
@martynmjones martynmjones mentioned this pull request May 5, 2023
Merged
4 tasks
@martynmjones martynmjones mentioned this pull request Mar 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@puntope puntope

Labels
changelog: add A new feature, function, or functionality was added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move GA4 implementation for blocks within the extension
2 participants
@puntope @eason9487