Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backend/src/main/java/edonymyeon/backend/notification/application/NotificationService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
📝 작업 요약
처음 올렸던 알림메시지 변경하기 PR에서 받은 피드백을 반영한 새 PR이에요!
🔎 작업 상세 설명
머지를 잘못해서 커밋 기록이 심하게 꼬이고 테스트도 자꾸 깨져서,
dev로부터 브랜치를 새로 만들고 제 작업 기록을 cheery-pick하는 방식으로 복구했어요!
피드백을 받은 이후에 작업한 내용을 쉽게 알아볼 수 있게 피드백 별로 커밋을 남겨두었으니,
커밋 별로 하나씩 보시면 편하실 거에요 :)
커밋 1 - 캐시 관리소 만들기
커밋 2 - 관리소 사용하기
커밋
커밋
커밋
🌟 리뷰 요구 사항