[sim] Various WebSockets fixes/enhancements #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PeterJohnson
commented
Dec 22, 2020
•
PeterJohnson
commented
- Update to match WebSockets spec
- Add support for builtin accelerometer
- SimValue: change "readonly" to "direction" to allow specifying bidirectional values ("<>" prefix in WS)
- Map SimDevice "Accel:Name" to WS type "Accel" deviceId "Name"
- Map SimValue enums to strings/double values on WS interface
- Copy Google doc to Markdown file in repo
- Other cleanups
- Add unit tests
This allows specifying bidirectional in addition to input and output. This change is specifically designed to avoid API and ABI breakage. This is completely transparent in C++; in Java a new callback class was added, and the old readonly functions have been marked deprecated.
PeterJohnson
added a commit
to PeterJohnson/allwpilib
that referenced
this pull request
Dec 24, 2020
These were broken by wpilibsuite#2952. Also fix Java ADXRS450_Gyro angle/rate SimValue names.
PeterJohnson
added a commit
that referenced
this pull request
Dec 24, 2020
These were broken by #2952. Also fix Java ADXRS450_Gyro angle/rate SimValue names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.