Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DutyCycleEncoder.setDistancePerRotation() in java simulation #5147

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix DutyCycleEncoder.setDistancePerRotation() in java simulation #5147

merged 2 commits into from
Mar 14, 2023

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Feb 28, 2023 •
edited
Loading

This was broken by #2952 and was not included in the fixes in #2963

@rzblue rzblue requested a review from a team as a code owner February 28, 2023 05:39
@Starlight220
Copy link
Member

Since the data is kept as a field in the object, I'm not sure we push it to SimDevice?

@rzblue
Copy link
Member Author

rzblue commented Feb 28, 2023

This is already implemented in C++.

@PeterJohnson PeterJohnson merged commit c886273 into wpilibsuite:main Mar 14, 2023
@rzblue rzblue mentioned this pull request Mar 28, 2023
Closed
@rzblue rzblue deleted the DutyCycleEncoder-sim-fix branch May 8, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzblue @Starlight220 @PeterJohnson