colors.description in Google calendar changes colour of time in the event's title

[indradhanush]

What's broken?

colors.description in Google calendar changes colour of time in the event's title.

For example, with the following configuration, where title is orange and description is white:

    gcal_0:
      type: gcal
      colors:
        title: "orange"
        description: "white"
        highlights:
        - ['Engineering team daily', 'lightblue']

And when I change the description to grey, I have:

There could be two possible approaches to fix this:

1. Leave the time of the event to a neutral color independent of title and description.
2. Set the color of time of the event to the same as that of the title.

Additionally, if we choose to go with 1. above, maybe we can add a colors.event_time to allow for customizing the time of the event, independent of this issue.

I'd be happy to dig into the code and try fixing this if this sounds reasonable and we can decide what approach would be best. 🙂

[senorprogrammer]

I think this is a left-over result. It used to be that "time" + ''title" = "description". But then "title" got the "highlights" capability and "time" got left behind. As such, colors.description only affects "time" now, I think.

I personally like "time" being a consistent colour: one colour for events that haven't happened yet, and another for events in the past (as is currently done for "time" + "title"). Having the future events colour be customizable sounds good.

I like your eventTime idea. That could be added in a backward-compatible manner by doing something like this in gcal/settings.go:57:

ymlConfig.UString("colors.eventTime", ymlConfig.UString("colors.description", "white"))

If you want to take a shot at making that work, that would be great. And if you have a better approach, feel free to go with that.