Add colors.eventTime to gcal #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senorprogrammer
requested changes
Sep 17, 2019
modules/gcal/settings.go
Outdated
| @@ -55,6 +56,7 @@ func NewSettingsFromYAML(name string, ymlConfig *config.Config, globalConfig *co | |||
|
|
|||
| settings.colors.day = ymlConfig.UString("colors.day", "forestgreen") | |||
| settings.colors.description = ymlConfig.UString("colors.description", "white") | |||
| settings.colors.eventTime = ymlConfig.UString("colors.eventTime", "white") | |||
There was a problem hiding this comment.
In the event that someone is already using descriptionColor to change the look of the time, we'll need to support that in a backwards-compatible way.
You can do that by changing this line to:
settings.colors.eventTime = ymlConfig.UString("colors.eventTime",ymlConfig.UString("colors.descriptionColor", "white"))
There was a problem hiding this comment.
I now understood your original comment on the issue. I was wondering if ymlConfig.UString occurring twice was a typo in that comment. 😅
This is a good idea. Fixed. 👌
indradhanush
force-pushed
the
feature/gcal-event-time-color
branch
from
6bf4a81
to
214bbca
Compare
This will let the user set a fixed color for the event time irrespective of colors used in highlights.
Color of description should not change the color of event time. This commit uses the independent setting color.eventTime instead. This defaults to "white" and is consistent with the current behaviour when a value for colors.description is not set. Fixes wtfutil#638
indradhanush
force-pushed
the
feature/gcal-event-time-color
branch
from
214bbca
to
9e2bc00
Compare
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638
Default setting:
Custom setting: