Remove Vue Select and Add Column Filter Slot #742
Conversation
|
@robgaston1 could you please add migration documentation for this as well? That would be immensely helpful.
|
| } | ||
| } | ||
| ``` | ||
| ::: tip Upgrading from versions 2.19.0-2.20.0 |
There was a problem hiding this comment.
@xaksis I wasn't sure where it was desirable to have the migration guide. I notice there are some things like that in the wiki, but wasn't sure if I can/should contribute to that.
I just put it here for now, but let me know if different.
| @@ -162,17 +145,25 @@ export default { | |||
| this.updateFilters(column, value); | |||
| }, | |||
|
|
|||
| updateSlotFilter(column, value) { | |||
| let fieldToFilter = column.filterOptions.slotFilterField || column.field; | |||
| if (typeof column.filterOptions.formatValue === 'function') { | |||
There was a problem hiding this comment.
This was an addition today, FYI. In working with this branch in our team project, I was formatting the filter data right before passing it in, but passing the function into the table made it much cleaner and enhanced reusability in our own codebase.
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
|
I only had a few PR comments, and they have all been resolved. I am able to run this branch locally and follow the documentation to migrate to manually adding vue-select into the new custom-filters slot. This seems to work as intended. Will wait on @xaksis to approve. Once merged the build size will be reduced by ~15% due to the removal of Vue-Select.
If merged this will resolve several other issues:
It will also effect this one #732. Debounce will need to be removed on custom filter slots |
|
@robgaston1 Fantastic! Thank you for this PR. @TheJaredWilcurt thank you for testing. So happy about the bundle size reduction. 👍 PR merged and released. |
|
All related issues and their stakeholders have been updated. All 7 "fixed by" issues closed. |
Addresses issue #675
Notes:
VgtFilterRowupdateSlotFilterthat includes the custom filter with the rest of the column filter valuesslotFilterFieldto be passed in, because the property used for display may not be the same as the property for filteringvue-selectcode to reduce the overall bundle size.