Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Vue Select and Add Column Filter Slot #742

Merged
merged 18 commits into from
Aug 9, 2020
Merged

Remove Vue Select and Add Column Filter Slot #742

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b695a94
remove vselect from package json
robgaston1 Jul 29, 2020
7f9b079
remove multiselect filter function
robgaston1 Jul 29, 2020
0722559
remove code from filter row component
robgaston1 Jul 29, 2020
91b1a0d
remove from index
robgaston1 Jul 29, 2020
f046754
remove vselect styling
robgaston1 Jul 29, 2020
940381c
remove remaining style and doc references to vue select
robgaston1 Jul 29, 2020
5ce194c
add column filter slot
robgaston1 Aug 5, 2020
9ef63c9
add documentation
robgaston1 Aug 5, 2020
e874512
add migration guide
robgaston1 Aug 6, 2020
66f6d1f
fix some mistakes and add the format value attribute
robgaston1 Aug 6, 2020
ade44bb
add back in classes and formatValue function
robgaston1 Aug 6, 2020
4d0d9be
Add safety check to format value function
robgaston1 Aug 6, 2020
3f7e046
Update dev/App.vue
robgaston1 Aug 7, 2020
69ca4b7
Update vp-docs/guide/advanced/README.md
robgaston1 Aug 7, 2020
b96d403
Update vp-docs/guide/advanced/README.md
robgaston1 Aug 7, 2020
0b5eb50
Update vp-docs/guide/advanced/README.md
robgaston1 Aug 7, 2020
0e74ebf
Update vp-docs/guide/advanced/README.md
robgaston1 Aug 7, 2020
07ff33c
Update vp-docs/guide/advanced/README.md
robgaston1 Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 3 additions & 36 deletions dev/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,31 +135,7 @@ export default {
'rematch',
],
},
},
{
label: 'Multiselect',
field: 'multiselect',
filterOptions: {
enabled: true,
filterMultiselectDropdownItems: [
{ id: 1, label: 'hello'},
'oh no'
],
},
},
{
label: 'Average age',
field: 'average',
type: 'number',
filterOptions: {
enabled: true,
filterMultiselectDropdownItems: [
1,
1.5,
2
],
},
},
}
],
rows: [
// { id:1, name:"John", age: 20, createdAt: '2018-02-18T00:00:43-05:00',score: 0.03343 },
Expand All @@ -171,7 +147,6 @@ export default {
score: 0.03343,
bool: true,
exact: 'match',
multiselect: 'hello',
average: 1
},
{
Expand All @@ -182,7 +157,6 @@ export default {
score: 0.03343,
bool: true,
exact: 'match',
multiselect: 'oh no',
average: null
},
{
Expand All @@ -192,8 +166,7 @@ export default {
createdAt: '2011-10-11',
score: 0.03343,
bool: false,
exact: null,
multiselect: null
exact: null
},
{
id: 5,
Expand All @@ -202,8 +175,7 @@ export default {
createdAt: '',
score: 0.03343,
bool: null,
exact: 'rematch',
multiselect: 'hello world',
exact: 'rematch'
robgaston1 marked this conversation as resolved.
Show resolved Hide resolved
average: 2
},
{
Expand All @@ -214,7 +186,6 @@ export default {
score: 0.03343,
bool: null,
exact: 'rematch',
multiselect: 'hello',
average: 3
},
{
Expand All @@ -225,7 +196,6 @@ export default {
score: 0.03343,
bool: null,
exact: null,
multiselect: 'hello',
average: 2
},
{
Expand All @@ -236,7 +206,6 @@ export default {
score: 0.03343,
bool: true,
exact: 'match',
multiselect: 'hello',
average: 1.5
},
{
Expand All @@ -247,7 +216,6 @@ export default {
score: null,
bool: 'false',
exact: null,
multiselect: 'hello',
average: 1
},
{
Expand All @@ -258,7 +226,6 @@ export default {
score: 0.03343,
bool: true,
exact: 'rematch',
multiselect: 'hello',
average: 1
},
],
Expand Down
54 changes: 42 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
"lodash.clonedeep": "^4.5.0",
"lodash.filter": "^4.6.0",
"lodash.foreach": "^4.5.0",
"lodash.isequal": "^4.5.0",
"vue-select": "^3.1.0"
"lodash.isequal": "^4.5.0"
},
"devDependencies": {
"eslint-config-airbnb": "^18.2.0",
Expand Down
Loading