Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package health #407

Merged
merged 25 commits into from
Oct 30, 2023
Merged

Package health #407

merged 25 commits into from
Oct 30, 2023

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Oct 29, 2023 •
edited
Loading

Description

Similar pangeo-data/climpred#832

  • pre-commit
  • setup.py
  • new py3.11, rm py3.8
  • make compatible with sklearn.calibration_curve

Type of change

  • package health

How Has This Been Tested?

CI

@aaronspring aaronspring self-assigned this Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #407 (33ca971) into main (80be142) will increase coverage by 0.02%.
Report is 11 commits behind head on main.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   94.73%   94.76%   +0.02%     
==========================================
  Files          26       27       +1     
  Lines        2794     2810      +16     
==========================================
+ Hits         2647     2663      +16     
  Misses        147      147
Files Coverage Δ
xskillscore/__init__.py 100.00% <100.00%> (ø)
xskillscore/core/comparative.py 86.86% <ø> (ø)
xskillscore/core/contingency.py 95.77% <100.00%> (ø)
xskillscore/core/deterministic.py 97.74% <ø> (ø)
xskillscore/core/probabilistic.py 89.78% <100.00%> (-0.04%) ⬇️
xskillscore/core/resampling.py 100.00% <ø> (ø)
xskillscore/core/stattests.py 97.22% <ø> (ø)
xskillscore/tests/test_accessor_deterministic.py 100.00% <ø> (ø)
xskillscore/tests/test_accessor_probabilistic.py 100.00% <ø> (ø)
xskillscore/tests/test_probabilistic.py 96.82% <100.00%> (+0.05%) ⬆️
... and 3 more

@aaronspring
Copy link
Collaborator Author

happy for more additions if useful @Zeitsperre

@aaronspring
Copy link
Collaborator Author

But no need to release IMO

@aaronspring
Copy link
Collaborator Author

aaronspring commented Oct 29, 2023 •
edited
Loading

Maybe need to fix upstream https://github.com/xarray-contrib/xskillscore/actions/runs/6683780563/job/18160354945#logs

Edit: Done

@raybellwaves
Copy link
Member

Thanks @aaronspring

@aaronspring aaronspring merged commit 683e1ed into main Oct 30, 2023
16 checks passed
@Zeitsperre Zeitsperre mentioned this pull request Nov 9, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raybellwaves raybellwaves raybellwaves approved these changes

Assignees

@aaronspring aaronspring

Labels
ci linting versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronspring @raybellwaves