Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest-lazy-fixtures, add classifiers and include LICENSE #410

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Zeitsperre
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Follows-up on #407

Type of change

  • Fixes a misnamed dependency (pytest-lazy-fixtures)
  • Adds package classifiers
  • Includes LICENSE.txt in package

Pre-Merge Checklist (final steps)

  • I have rebased onto main or develop (wherever I am merging) and dealt with any conflicts.
  • I have squashed commits to a reasonable amount, and force-pushed the squashed commits.

@pep8speaks
Copy link

pep8speaks commented Nov 9, 2023

Hello @Zeitsperre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-09 16:15:37 UTC

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #410 (575c696) into main (80be142) will increase coverage by 0.02%.
Report is 12 commits behind head on main.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   94.73%   94.76%   +0.02%     
==========================================
  Files          26       27       +1     
  Lines        2794     2810      +16     
==========================================
+ Hits         2647     2663      +16     
  Misses        147      147              
Files Coverage Δ
xskillscore/__init__.py 100.00% <100.00%> (ø)
xskillscore/core/comparative.py 86.86% <ø> (ø)
xskillscore/core/contingency.py 95.77% <100.00%> (ø)
xskillscore/core/deterministic.py 97.74% <ø> (ø)
xskillscore/core/probabilistic.py 89.78% <100.00%> (-0.04%) ⬇️
xskillscore/core/resampling.py 100.00% <ø> (ø)
xskillscore/core/stattests.py 97.22% <ø> (ø)
xskillscore/tests/test_accessor_deterministic.py 100.00% <ø> (ø)
xskillscore/tests/test_accessor_probabilistic.py 100.00% <ø> (ø)
xskillscore/tests/test_probabilistic.py 96.82% <100.00%> (+0.05%) ⬆️
... and 3 more

@aaronspring aaronspring merged commit aa293ff into xarray-contrib:main Nov 9, 2023
16 checks passed
@Zeitsperre Zeitsperre deleted the patch-1 branch November 9, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants