feat: update Jest to version 27 #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herschel666
added
📦 master
herschel666
force-pushed
the
update-jest-to-27
branch
2 times, most recently
from
be56286
to
5b81746
Compare
ZauberNerd
previously approved these changes
Jun 7, 2021
herschel666
force-pushed
the
update-jest-to-27
branch
2 times, most recently
from
af33ad8
to
b23b21e
Compare
ZauberNerd
approved these changes
Jun 7, 2021
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2021
1844: feat: update Jest to version 27 r=ZauberNerd a=herschel666 The Canarist tests aren't helpful here, because the dependency tree of the Canarist test monorepo contains both Jest v26 & Jest v27 packages. This won't work. closes #1760 #1761 #1831 #1832 #1838 #1839 <details> <summary>Bors merge bot cheat sheet</summary> We are using [bors-ng](https://github.com/bors-ng/bors-ng) to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of `bors delegate+` or `bors delegate=[list]`). | Syntax | Description | | --- | --- | | bors merge | Run the test suite and push to master if it passes. Short for "reviewed: looks good." | | bors merge- | Cancel an r+, r=, merge, or merge= | | bors try | Run the test suite without pushing to master. | | bors try- | Cancel a try | | bors delegate+ | Allow the pull request author to merge their changes. | | bors delegate=[list] | Allow the listed users to r+ this pull request's changes. | | bors retry | Run the previous command a second time. | This is a short collection of opinionated commands. For a full list of the commands read the [bors reference](https://bors.tech/documentation/). </details> Co-authored-by: Emanuel Kluge <[email protected]>
|
Build failed:
|
ZauberNerd
suggested changes
Jun 7, 2021
|
And to get the canarist tests green, we could add |
That's right, but it doesn't give us any clue on whether the preset will really work with both v26 and v27. Will do it anyway, so we'll be able to use bors for merging. 👍 |
added 4 commits
June 8, 2021 08:05
...temporarily in order to make them succeed.
herschel666
force-pushed
the
update-jest-to-27
branch
from
b23b21e
to
30dbf6a
Compare
ZauberNerd
approved these changes
Jun 8, 2021
|
bors merge |
|
Build succeeded:
|
|
Cherry-pick failed on branch v14.x! Please check out PR #1855 & resolve the conflicts. |
Merged
1 task
bors bot
added a commit
that referenced
this pull request
Jun 8, 2021
1855: feat: update Jest to version 27 (v14.x) r=herschel666 a=hops-release-bot[bot] :warning: **This PR is the successor of #1844 and has been created automatically because the previous PR's commits could not be cherry-picked.**⚠️ Co-authored-by: Emanuel Kluge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Canarist tests aren't helpful here, because the dependency tree of the Canarist test monorepo contains both Jest v26 & Jest v27 packages. This won't work.
closes #1760 #1761 #1831 #1832 #1838 #1839
Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of
bors delegate+orbors delegate=[list]).This is a short collection of opinionated commands. For a full list of the commands read the bors reference.