[Proposal] New setting to not reuse LVM volume groups

package/yast2-storage-ng.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Tue Nov 29 15:07:25 UTC 2022 - Ancor Gonzalez Sosa <[email protected]>
+
+- Proposal: new setting to prevent reusing LVM volume groups
+  (related to gh#yast/d-installer#264).
+
 -------------------------------------------------------------------
 Mon Nov 21 11:33:52 UTC 2022 - Ancor Gonzalez Sosa <[email protected]>
 

src/lib/y2storage/proposal/lvm_helper.rb

@@ -169,6 +169,11 @@ def new_volume_group
       #
       # @return [Boolean]
       def try_to_reuse?
+        # Setting introduced to completely avoid LVM reusing in D-Installer.
+        # It's a new playground, so no need to carry YaST behaviors that have
+        # proven to be confusing.
+        return false if settings.lvm_vg_reuse == false
+
         # We introduced this when we still didn't have a mechanism to activate
         # existing LUKS. Now such mechanism exists but this check has never been
         # removed. Nobody complained so far.

src/lib/y2storage/proposal_settings.rb

@@ -219,6 +219,11 @@ def candidate_devices=(devices)
     #   specify the predefined size of the LVM volume group.
     attr_accessor :lvm_vg_size
 
+    # @return [Boolean] whether a pre-existing LVM volume group should be reused if
+    #   the conditions to do so are met. That is the historical YaST behavior, which
+    #   can be inhibited by setting this to false.
+    attr_accessor :lvm_vg_reuse
+
     # @return [Array<VolumeSpecification>] list of volumes specifications used during
     #   the proposal
     attr_accessor :volumes
@@ -398,6 +403,7 @@ def root_volume
       linux_delete_mode:          :ondemand,
       lvm:                        false,
       lvm_vg_strategy:            :use_available,
+      lvm_vg_reuse:               true,
       encryption_method:          EncryptionMethod::LUKS1,
       multidisk_first:            false,
       other_delete_mode:          :ondemand,

test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm-sep-home.yml

@@ -0,0 +1,44 @@
+---
+- disk:
+    name: "/dev/sda"
+    size: 800 GiB
+    partition_table: msdos
+    partitions:
+
+    - partition:
+        size: 730 GiB
+        name: /dev/sda1
+        id: ntfs
+        file_system: ntfs
+        label: windows
+
+    - partition:
+        size: unlimited
+        name: /dev/sda2
+        id: lvm
+
+- lvm_vg:
+    vg_name: system
+    lvm_lvs:
+
+    - lvm_lv:
+        lv_name: root
+        size: 40 GiB
+        file_system: btrfs
+        mount_point: "/"
+
+    - lvm_lv:
+        lv_name: home
+        size: 28668 MiB
+        file_system: xfs
+        mount_point: "/home"
+
+    - lvm_lv:
+        lv_name: swap
+        size: 2 GiB
+        file_system: swap
+        mount_point: swap
+
+    lvm_pvs:
+    - lvm_pv:
+        blk_device: /dev/sda2

test/data/devicegraphs/output/windows-linux-lvm-noreuse-lvm.yml

@@ -0,0 +1,45 @@
+---
+- disk:
+    name: "/dev/sda"
+    size: 800 GiB
+    partition_table: msdos
+    partitions:
+
+    - partition:
+        size: 730 GiB
+        name: /dev/sda1
+        id: ntfs
+        file_system: ntfs
+        label: windows
+
+    - partition:
+        size: 50 GiB
+        name: /dev/sda2
+        id: lvm
+
+    - partition:
+        size: unlimited
+        name: /dev/sda3
+        id: 0xb
+        file_system: vfat
+        label: recovery
+
+- lvm_vg:
+    vg_name: system
+    lvm_lvs:
+
+    - lvm_lv:
+        lv_name: root
+        size: 40 GiB
+        file_system: btrfs
+        mount_point: "/"
+
+    - lvm_lv:
+        lv_name: swap
+        size: 2 GiB
+        file_system: swap
+        mount_point: swap
+
+    lvm_pvs:
+    - lvm_pv:
+        blk_device: /dev/sda2

test/y2storage/proposal/lvm_helper_test.rb

@@ -64,6 +64,14 @@
           expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
         end
       end
+
+      context "and ProposalSettings#lvm_vg_reuse is set to false" do
+        before { settings.lvm_vg_reuse = false }
+
+        it "returns an empty array" do
+          expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
+        end
+      end
     end
 
     context "if some volume groups are big enough" do
@@ -102,6 +110,14 @@
           expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
         end
       end
+
+      context "and ProposalSettings#lvm_vg_reuse is set to false" do
+        before { settings.lvm_vg_reuse = false }
+
+        it "returns an empty array" do
+          expect(helper.reusable_volume_groups(fake_devicegraph)).to eq []
+        end
+      end
     end
   end
 

test/y2storage/proposal_scenarios_x86_test.rb

@@ -84,6 +84,13 @@
       let(:scenario) { "windows-linux-lvm-pc" }
       include_examples "LVM-based proposed layouts"
       include_examples "partition-based proposed layouts"
+
+      context "if the proposal is configured to not reuse volume groups" do
+        before { settings.lvm_vg_reuse = false }
+
+        let(:expected_scenario) { "windows-linux-lvm-noreuse" }
+        include_examples "LVM-based proposed layouts"
+      end
     end
 
     context "in a windows-only PC with GPT partition table" do