[Proposal] New setting to not reuse LVM volume groups #1316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For historical reasons, YaST tries to reuse existing LVM volume groups when making a proposal.
That behavior can be very confusing in many situations. Some of the associated problems and historical factors are described here:
https://trello.com/c/Ib7QC298/19-proposal-strategy-for-reusing-stuff-in-proposal-bug1091998-and-others
Now
Y2Storage::GuidedProposal
is also used by D-Installer and we don't want to follow the YaST approach for reusing stuff. Since D-Installer represents a new playground, we don't need to play by the old rules and expectations.Solution
Introduce a new setting into
Y2Storage::ProposalSettings
that will be used only by D-Installer (for the time being) and that will inhibit the mechanism to reuse existing LVM volume groups.Testing
Added unit tests. Backwards compatibility ensured because all the previous tests keep working with no modification.
Note about the version
Version of the package not bumped because we are not in a hurry to submit this to Factory and @jreidinger is already working on another change for yast-storage-ng.