Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] New setting to not reuse LVM volume groups #1316

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Nov 29, 2022

Problem

For historical reasons, YaST tries to reuse existing LVM volume groups when making a proposal.

That behavior can be very confusing in many situations. Some of the associated problems and historical factors are described here:
https://trello.com/c/Ib7QC298/19-proposal-strategy-for-reusing-stuff-in-proposal-bug1091998-and-others

Now Y2Storage::GuidedProposal is also used by D-Installer and we don't want to follow the YaST approach for reusing stuff. Since D-Installer represents a new playground, we don't need to play by the old rules and expectations.

Solution

Introduce a new setting into Y2Storage::ProposalSettings that will be used only by D-Installer (for the time being) and that will inhibit the mechanism to reuse existing LVM volume groups.

Testing

Added unit tests. Backwards compatibility ensured because all the previous tests keep working with no modification.

Note about the version

Version of the package not bumped because we are not in a hurry to submit this to Factory and @jreidinger is already working on another change for yast-storage-ng.

@coveralls
Copy link

coveralls commented Nov 29, 2022

Coverage Status

Coverage increased (+0.0002%) to 97.754% when pulling 79a4eff on ancorgs:lvm_vg_reuse into 64989e4 on yast:master.

@ancorgs ancorgs marked this pull request as ready for review November 29, 2022 15:19
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is no need to bump the version but we need to make sure that the change is available in the YaST:Head:D-Installer project too (it is linked, so it should be available).

@ancorgs ancorgs merged commit 3edf159 into yast:master Nov 29, 2022
@yast-bot
Copy link

✔️ Internal Jenkins job #1135 successfully finished

@yast-bot
Copy link

yast-bot commented Dec 1, 2022

✔️ Public Jenkins job #449 successfully finished

@dgdavid dgdavid mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants