YDB FQ: validate `DATABASE_NAME` field #5984

skywalker-jpg · 2024-06-26T13:56:13Z

Changelog entry

Changelog category

Improvement

Additional information

github-actions · 2024-06-26T14:18:04Z

⚪ 2024-06-26 14:18:04 UTC Pre-commit check for 11376ed has started.
⚪ 2024-06-26 14:21:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 14:22:25 UTC Build successful.
⚪ 2024-06-26 14:22:37 UTC Tests are running...
🔴 2024-06-26 16:28:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9750	9161	0	84	324	181

🟢 2024-06-26 16:29:19 UTC ydbd size 5.5 GiB changed* by +32.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ed1e090`	merge: `11376ed`	diff	diff %
ydbd size	5 914 295 664 Bytes	5 914 328 824 Bytes	+32.4 KiB	+0.001%
ydbd stripped size	1 270 541 736 Bytes	1 270 549 928 Bytes	+8.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-26T14:22:04Z

⚪ 2024-06-26 14:22:04 UTC Pre-commit check for 11376ed has started.
⚪ 2024-06-26 14:24:28 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-26 14:25:59 UTC Build successful.

github-actions · 2024-06-26T14:23:52Z

⚪ 2024-06-26 14:23:52 UTC Pre-commit check for 11376ed has started.
⚪ 2024-06-26 14:26:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 14:27:38 UTC Build successful.
⚪ 2024-06-26 14:27:51 UTC Tests are running...
🔴 2024-06-26 16:24:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37404	32222	0	5	5154	23

🟢 2024-06-26 16:25:06 UTC ydbd size 8.4 GiB changed* by +31.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ed1e090`	merge: `11376ed`	diff	diff %
ydbd size	9 019 580 888 Bytes	9 019 612 712 Bytes	+31.1 KiB	+0.000%
ydbd stripped size	492 614 504 Bytes	492 619 944 Bytes	+5.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/fq/libs/control_plane_storage/request_validators.cpp

ydb/core/external_sources/external_data_source.cpp

ydb/core/fq/libs/control_plane_storage/request_validators.cpp

github-actions · 2024-06-28T08:15:17Z

⚪ 2024-06-28 08:15:16 UTC Pre-commit check for ad6a811 has started.
⚪ 2024-06-28 08:17:52 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-06-28 08:18:22 UTC Check cancelled

github-actions · 2024-06-28T08:26:08Z

⚪ 2024-06-28 08:26:08 UTC Pre-commit check for 19ef286 has started.
⚪ 2024-06-28 08:28:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-28 09:07:19 UTC Build successful.

github-actions · 2024-06-28T08:26:57Z

⚪ 2024-06-28 08:26:57 UTC Pre-commit check for 19ef286 has started.
⚪ 2024-06-28 08:29:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-28 08:54:07 UTC Build successful.
⚪ 2024-06-28 08:54:23 UTC Tests are running...
🔴 2024-06-28 10:58:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9763	9164	0	91	323	185

🟢 2024-06-28 10:59:06 UTC ydbd size 5.5 GiB changed* by +39.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4fde7f6`	merge: `19ef286`	diff	diff %
ydbd size	5 918 167 032 Bytes	5 918 207 312 Bytes	+39.3 KiB	+0.001%
ydbd stripped size	1 271 364 616 Bytes	1 271 367 784 Bytes	+3.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-28T08:27:07Z

⚪ 2024-06-28 08:27:07 UTC Pre-commit check for 19ef286 has started.
⚪ 2024-06-28 08:29:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-28 09:12:47 UTC Build successful.
⚪ 2024-06-28 09:13:03 UTC Tests are running...
🔴 2024-06-28 11:21:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38214	32998	0	7	5182	27

🟢 2024-06-28 11:22:07 UTC ydbd size 8.4 GiB changed* by +37.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4fde7f6`	merge: `19ef286`	diff	diff %
ydbd size	9 024 303 504 Bytes	9 024 341 600 Bytes	+37.2 KiB	+0.000%
ydbd stripped size	492 866 760 Bytes	492 868 552 Bytes	+1.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/fq/libs/control_plane_storage/request_validators.cpp

ydb/core/external_sources/external_data_source.cpp

ydb/core/fq/libs/control_plane_storage/request_validators.cpp

github-actions · 2024-07-08T11:19:53Z

⚪ 2024-07-08 11:19:53 UTC Pre-commit check for 7e83154 has started.
⚪ 2024-07-08 11:22:48 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-08 11:24:42 UTC Check cancelled

github-actions · 2024-07-08T11:21:23Z

⚪ 2024-07-08 11:21:22 UTC Pre-commit check for 7e83154 has started.
⚫ 2024-07-08 11:24:27 UTC Check cancelled

github-actions · 2024-07-08T11:27:40Z

⚪ 2024-07-08 11:27:40 UTC Pre-commit check for 57b9690 has started.
⚪ 2024-07-08 11:30:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 12:12:15 UTC Build successful.
⚪ 2024-07-08 12:12:28 UTC Tests are running...
🔴 2024-07-08 14:11:29 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9869	9285	0	82	324	178

🟡 2024-07-08 14:12:15 UTC ydbd size 5.2 GiB changed* by +246.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ab119a2`	merge: `57b9690`	diff	diff %
ydbd size	5 614 359 056 Bytes	5 614 611 496 Bytes	+246.5 KiB	+0.004%
ydbd stripped size	1 210 032 824 Bytes	1 210 075 992 Bytes	+42.2 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-08T11:27:52Z

⚪ 2024-07-08 11:27:51 UTC Pre-commit check for 57b9690 has started.
⚪ 2024-07-08 11:30:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 12:00:00 UTC Build successful.

github-actions · 2024-07-08T11:31:26Z

⚪ 2024-07-08 11:31:26 UTC Pre-commit check for 57b9690 has started.
⚪ 2024-07-08 11:34:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 12:29:13 UTC Build successful.
⚪ 2024-07-08 12:29:26 UTC Tests are running...
🔴 2024-07-08 14:10:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38374	33133	0	7	5220	14

🟡 2024-07-08 14:11:35 UTC ydbd size 8.1 GiB changed* by +199.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ab119a2`	merge: `57b9690`	diff	diff %
ydbd size	8 721 967 904 Bytes	8 722 171 856 Bytes	+199.2 KiB	+0.002%
ydbd stripped size	476 639 288 Bytes	476 649 144 Bytes	+9.6 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Co-authored-by: Timur Sufiyanov <[email protected]>

…orm#6298 ydb-platform#6471 ydb-platform#6484 ydb-platform#6703 (ydb-platform#6721) Co-authored-by: Timur Sufiyanov <[email protected]>

…orm#6298 ydb-platform#6471 ydb-platform#6484 ydb-platform#6703 (ydb-platform#6721)

[add] validation

2c9425a

skywalker-jpg requested a review from a team as a code owner June 26, 2024 13:56

github-actions bot added the improvement label Jun 26, 2024

vitalyisaev2 requested changes Jun 26, 2024

View reviewed changes

ydb/core/fq/libs/control_plane_storage/request_validators.cpp Outdated Show resolved Hide resolved

ydb/core/external_sources/external_data_source.cpp Outdated Show resolved Hide resolved

ydb/core/fq/libs/control_plane_storage/request_validators.cpp Outdated Show resolved Hide resolved

[refactor]

c40641e

[refactor]

443a096

dorooleg reviewed Jun 28, 2024

View reviewed changes

ydb/core/fq/libs/control_plane_storage/request_validators.cpp Outdated Show resolved Hide resolved

dorooleg reviewed Jun 28, 2024

View reviewed changes

ydb/core/fq/libs/control_plane_storage/request_validators.cpp Show resolved Hide resolved

vitalyisaev2 previously approved these changes Jul 5, 2024

View reviewed changes

uzhastik reviewed Jul 5, 2024

View reviewed changes

ydb/core/external_sources/external_data_source.cpp Outdated Show resolved Hide resolved

ydb/core/external_sources/external_data_source.cpp Outdated Show resolved Hide resolved

ydb/core/fq/libs/control_plane_storage/request_validators.cpp Outdated Show resolved Hide resolved

[refactor]

9534f66

skywalker-jpg dismissed vitalyisaev2’s stale review via 9534f66 July 8, 2024 11:08

uzhastik reviewed Jul 8, 2024

View reviewed changes

ydb/core/fq/libs/control_plane_storage/request_validators.cpp Outdated Show resolved Hide resolved

[refactor]

62dbfb8

[refactor]

288b0c4

uzhastik approved these changes Jul 8, 2024

View reviewed changes

vitalyisaev2 changed the title ~~YQ:3368 Add Database validation~~ YDB FQ: validate DATABASE_NAME field Jul 8, 2024

vitalyisaev2 merged commit ec0e7ed into ydb-platform:main Jul 8, 2024
9 of 13 checks passed

This was referenced Jul 9, 2024

Kqprun added request time info printing #6479

Merged

YQ-3405 fixed endless retries for external error #6626

Merged

YQ-3345 fixed WM counters and unit test #6643

Merged

vitalyisaev2 pushed a commit to vitalyisaev2/ydb that referenced this pull request Jul 16, 2024

YDB FQ: validate DATABASE_NAME field (ydb-platform#5984)

2c19f19

vitalyisaev2 mentioned this pull request Jul 16, 2024

Merge #5932 #5984 #6257 #6298 #6471 #6484 #6703 #6721

Merged

vitalyisaev2 pushed a commit to vitalyisaev2/ydb that referenced this pull request Jul 16, 2024

YDB FQ: validate DATABASE_NAME field (ydb-platform#5984)

3e8cdb1

vitalyisaev2 mentioned this pull request Jul 16, 2024

Merge #5984 #6257 #6298 #6471 #6484 #6703 #6724

Merged

vitalyisaev2 added a commit that referenced this pull request Jul 16, 2024

Merge #5932 #5984 #6257 #6298 #6471 #6484 #6703 (#6721)

4968dab

Co-authored-by: Timur Sufiyanov <[email protected]>

vitalyisaev2 added a commit that referenced this pull request Jul 16, 2024

Merge #5984 #6257 #6298 #6471 #6484 #6703 (#6724)

ee016ff

Co-authored-by: Timur Sufiyanov <[email protected]>

GrigoriyPA mentioned this pull request Jul 24, 2024

YQ WM fix for sls feature flag #7057

Merged

uzhastik added a commit to uzhastik/ydb that referenced this pull request Sep 12, 2024

Merge ydb-platform#5932 ydb-platform#5984 ydb-platform#6257 ydb-platf…

cfd84af

…orm#6298 ydb-platform#6471 ydb-platform#6484 ydb-platform#6703 (ydb-platform#6721)

GrigoriyPA mentioned this pull request Sep 26, 2024

YQ-3684 fix screts not found error handling #9822

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YDB FQ: validate `DATABASE_NAME` field #5984

YDB FQ: validate `DATABASE_NAME` field #5984

skywalker-jpg commented Jun 26, 2024

github-actions bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

YDB FQ: validate DATABASE_NAME field #5984

YDB FQ: validate DATABASE_NAME field #5984

Conversation

skywalker-jpg commented Jun 26, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Jun 26, 2024 • edited Loading

github-actions bot commented Jun 26, 2024 • edited Loading

github-actions bot commented Jun 26, 2024 • edited Loading

github-actions bot commented Jun 28, 2024 • edited Loading

github-actions bot commented Jun 28, 2024 • edited Loading

github-actions bot commented Jun 28, 2024 • edited Loading

github-actions bot commented Jun 28, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

YDB FQ: validate `DATABASE_NAME` field #5984

YDB FQ: validate `DATABASE_NAME` field #5984

github-actions bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading