-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YDB FQ: Support MDB MySQL in DatabaseResolver #6257
Conversation
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
} | ||
|
||
// check if all services of a particular host are alive | ||
bool alive = std::all_of( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вытащи контейнер в отдельную переменную, у тебя дублирование и непонятное время жизни результата at().
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
This reverts commit a6924c2.
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Надо починить отступы
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…orm#6298 ydb-platform#6471 ydb-platform#6484 ydb-platform#6703 (ydb-platform#6721) Co-authored-by: Timur Sufiyanov <[email protected]>
…orm#6298 ydb-platform#6471 ydb-platform#6484 ydb-platform#6703 (ydb-platform#6721) Co-authored-by: Timur Sufiyanov <[email protected]>
Changelog entry
Changelog category
Additional information