Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDB FQ: Support MDB MySQL in DatabaseResolver #6257

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

skywalker-jpg
Copy link
Contributor

@skywalker-jpg skywalker-jpg commented Jul 3, 2024

Changelog entry

  • YDB FQ: Support MDB MySQL in DatabaseResolver

Changelog category

  • New feature

Additional information

@skywalker-jpg skywalker-jpg requested a review from a team as a code owner July 3, 2024 13:05
Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 14:39:05 UTC Pre-commit check for bbdda04 has started.
2024-07-03 14:42:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 15:05:31 UTC Build successful.
2024-07-03 15:05:42 UTC Tests are running...
🔴 2024-07-03 17:08:00 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9847 9265 0 87 322 173

🟢 2024-07-03 17:08:52 UTC ydbd size 5.3 GiB changed* by -98.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: bbdda04 diff diff %
ydbd size 5 814 908 560 Bytes 5 711 994 040 Bytes -98.1 MiB -1.770%
ydbd stripped size 1 247 931 016 Bytes 1 235 262 760 Bytes -12.1 MiB -1.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 14:47:44 UTC Pre-commit check for bbdda04 has started.
2024-07-03 14:50:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 14:54:54 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 15:17:16 UTC Pre-commit check for bbdda04 has started.
2024-07-03 15:20:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 16:00:20 UTC Build successful.
2024-07-03 16:00:32 UTC Tests are running...
🔴 2024-07-03 17:55:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38305 33102 0 3 5187 13

🟢 2024-07-03 17:56:32 UTC ydbd size 8.2 GiB changed* by -145.0 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: bbdda04 diff diff %
ydbd size 8 926 807 928 Bytes 8 774 808 336 Bytes -145.0 MiB -1.703%
ydbd stripped size 486 814 568 Bytes 482 672 424 Bytes -4.0 MiB -0.851%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@skywalker-jpg skywalker-jpg changed the title Yq 3365 YDB FQ: Add MySQL parser Jul 3, 2024
@vitalyisaev2 vitalyisaev2 changed the title YDB FQ: Add MySQL parser YDB FQ: Support MDB MySQL in database_resolver.cpp Jul 3, 2024
@vitalyisaev2 vitalyisaev2 changed the title YDB FQ: Support MDB MySQL in database_resolver.cpp YDB FQ: Support MDB MySQL in DatabaseResolver Jul 3, 2024
vitalyisaev2
vitalyisaev2 previously approved these changes Jul 3, 2024
}

// check if all services of a particular host are alive
bool alive = std::all_of(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вытащи контейнер в отдельную переменную, у тебя дублирование и непонятное время жизни результата at().

ydb/core/fq/libs/actors/database_resolver.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 15:40:50 UTC Pre-commit check for 8cc6f34 has started.
2024-07-04 15:43:41 UTC Build linux-x86_64-release-clang14 is running...
2024-07-04 15:44:59 UTC Check cancelled

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 15:50:36 UTC Pre-commit check for 967437f has started.
2024-07-04 15:53:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 15:56:27 UTC Build successful.

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 16:15:10 UTC Pre-commit check for 967437f has started.
2024-07-04 16:17:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-04 16:40:13 UTC Build successful.
2024-07-04 16:40:28 UTC Tests are running...
🔴 2024-07-04 17:04:42 UTC Test run completed, no test results found for commit ee678e8. Please check test log.
🟢 2024-07-04 17:05:17 UTC ydbd size 5.3 GiB changed* by +47.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 29e1e45 merge: 967437f diff diff %
ydbd size 5 712 635 128 Bytes 5 712 683 768 Bytes +47.5 KiB +0.001%
ydbd stripped size 1 235 400 808 Bytes 1 235 409 832 Bytes +8.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-04 17:05:18 UTC Check cancelled

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 16:15:52 UTC Pre-commit check for 967437f has started.
2024-07-04 16:18:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-04 16:56:23 UTC Build successful.
2024-07-04 16:56:36 UTC Tests are running...
🔴 2024-07-04 17:04:41 UTC Test run completed, no test results found for commit ee678e8. Please check test log.
🟢 2024-07-04 17:05:23 UTC ydbd size 8.2 GiB changed* by +85.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f256aea merge: 967437f diff diff %
ydbd size 8 775 766 704 Bytes 8 775 854 336 Bytes +85.6 KiB +0.001%
ydbd stripped size 482 728 232 Bytes 482 730 728 Bytes +2.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-04 17:05:24 UTC Check cancelled

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 17:26:23 UTC Pre-commit check for 54cf267 has started.
2024-07-04 17:28:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 17:33:03 UTC Build successful.

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 17:32:03 UTC Pre-commit check for 54cf267 has started.
2024-07-04 17:35:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-04 17:58:31 UTC Build successful.
2024-07-04 17:58:46 UTC Tests are running...
🔴 2024-07-04 19:51:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9849 9273 0 83 322 171

🟢 2024-07-04 19:51:42 UTC ydbd size 5.3 GiB changed* by +48.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 29e1e45 merge: 54cf267 diff diff %
ydbd size 5 712 635 128 Bytes 5 712 684 344 Bytes +48.1 KiB +0.001%
ydbd stripped size 1 235 400 808 Bytes 1 235 409 832 Bytes +8.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 4, 2024

2024-07-04 17:32:42 UTC Pre-commit check for 54cf267 has started.
2024-07-04 17:35:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-04 18:14:08 UTC Build successful.
2024-07-04 18:14:22 UTC Tests are running...
🔴 2024-07-04 19:56:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38345 33114 0 1 5220 10

🟢 2024-07-04 19:57:29 UTC ydbd size 8.2 GiB changed* by +99.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 29e1e45 merge: 54cf267 diff diff %
ydbd size 8 775 754 584 Bytes 8 775 856 432 Bytes +99.5 KiB +0.001%
ydbd stripped size 482 727 976 Bytes 482 730 792 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ydb/core/fq/libs/actors/ut/database_resolver_ut.cpp Outdated Show resolved Hide resolved
ydb/core/fq/libs/actors/database_resolver.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vitalyisaev2 vitalyisaev2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо починить отступы

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 14:04:09 UTC Pre-commit check for e8f17a5 has started.
2024-07-05 14:07:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-05 14:12:13 UTC Build successful.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 14:23:02 UTC Pre-commit check for e8f17a5 has started.
2024-07-05 14:26:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-05 15:04:05 UTC Build successful.
2024-07-05 15:04:18 UTC Tests are running...
🔴 2024-07-05 16:44:37 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38358 33126 0 1 5220 11

🟢 2024-07-05 16:45:13 UTC ydbd size 8.1 GiB changed* by -272.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5fc09ca merge: e8f17a5 diff diff %
ydbd size 8 726 129 816 Bytes 8 725 850 752 Bytes -272.5 KiB -0.003%
ydbd stripped size 477 144 232 Bytes 476 979 112 Bytes -161.2 KiB -0.035%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 14:39:47 UTC Pre-commit check for e8f17a5 has started.
2024-07-05 14:43:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-05 15:05:51 UTC Build successful.
2024-07-05 15:06:01 UTC Tests are running...
🔴 2024-07-05 17:04:29 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9854 9274 0 86 321 173

🟢 2024-07-05 17:05:17 UTC ydbd size 5.2 GiB changed* by -121.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5fc09ca merge: e8f17a5 diff diff %
ydbd size 5 615 862 464 Bytes 5 615 737 992 Bytes -121.6 KiB -0.002%
ydbd stripped size 1 211 107 272 Bytes 1 211 126 312 Bytes +18.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitalyisaev2 vitalyisaev2 merged commit 1d57390 into ydb-platform:main Jul 8, 2024
8 of 12 checks passed
vitalyisaev2 pushed a commit to vitalyisaev2/ydb that referenced this pull request Jul 16, 2024
vitalyisaev2 pushed a commit to vitalyisaev2/ydb that referenced this pull request Jul 16, 2024
vitalyisaev2 added a commit that referenced this pull request Jul 16, 2024
vitalyisaev2 added a commit that referenced this pull request Jul 16, 2024
Co-authored-by: Timur Sufiyanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants