Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit log linting not checking all PR commits #1045

Closed
llorllale opened this issue Jan 27, 2019 · 3 comments
Closed

Commit log linting not checking all PR commits #1045

llorllale opened this issue Jan 27, 2019 · 3 comments

Comments

@llorllale
Copy link
Contributor

This is due to an erroneous assumption: the linter would be run in the feature branch. The problem is that both rultor and travis run scripts after merging the feature and master branches together.

In this context, the --not master predicate passed to git log does not produce the expected output.

I thought about using git's --author filter but neither travis nor rultor expose the PR's author. (Regarding rultor, let's keep in mind that there are sometimes unicode decoding issues, so we'll keep gitlint disabled in rultor for now).

Since there are many dirty messages in our commit history, we should just lint all commit logs since a last known good revision. I would choose d0b2b05 but git log d0b2b05d977b43d705f89f1c286a4262b534c6b4.. includes many commits I did not expect and I don't know yet why it does that.

So for now git log --since="2019-01-21" produces an output that we can work on, so we'll use that.

@llorllale
Copy link
Contributor Author

@llorllale fixed in ab8f142

@0crat
Copy link
Collaborator

0crat commented Jan 27, 2019

Job gh:yegor256/cactoos#1045 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 27, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants