Remove nulls from UncheckedProc #885 #1029

victornoel · 2019-01-20T17:37:58Z

This is for #885

0crat · 2019-01-20T17:42:15Z

Job #1029 is now in scope, role is REV

codecov-io · 2019-01-20T17:43:00Z

Codecov Report

Merging #1029 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1029      +/-   ##
============================================
+ Coverage      87.4%   87.47%   +0.06%     
  Complexity     1515     1515              
============================================
  Files           266      266              
  Lines          3884     3887       +3     
  Branches        212      212              
============================================
+ Hits           3395     3400       +5     
+ Misses          440      438       -2     
  Partials         49       49

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/func/UncheckedProc.java	`100% <100%> (ø)`	`2 <1> (ø)`	⬇️
src/main/java/org/cactoos/func/IoCheckedProc.java	`100% <0%> (+33.33%)`	`2% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67d300...9502abf. Read the comment docs.

0crat · 2019-01-20T17:43:07Z

This pull request #1029 is assigned to @fabriciofx /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

fabriciofx

@victornoel Done. Please, check out.

fabriciofx · 2019-01-20T18:25:56Z

src/main/java/org/cactoos/func/UncheckedProc.java

@@ -53,7 +52,11 @@ public UncheckedProc(final Proc<X> prc) {

    @Override
    public void exec(final X input) {
-        new UncheckedFunc<>(new FuncOf<>(this.proc, null)).apply(input);
+        try {


@victornoel Please, can you add some tests here?

@fabriciofx there already are tests for this class

@victornoel Right. Thanks!

@victornoel you can use CheckedScalar here

@llorllale if I use CheckedScalar then I will need to specify an object to be returned, and then I will put null :) FuncOf does use one of the Scalar class for example

fabriciofx · 2019-01-20T19:01:25Z

@victornoel This PR seems fine. Thanks! @llorllale Can you merge it now?

fabriciofx · 2019-01-20T19:01:31Z

@rultor merge

rultor · 2019-01-20T19:02:24Z

@rultor merge

@fabriciofx Thanks for your request. @llorllale Please confirm this.

llorllale · 2019-01-22T01:05:32Z

@rultor merge

rultor · 2019-01-22T01:06:16Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-22T01:09:27Z

@rultor merge

@llorllale @victornoel Oops, I failed. You can see the full log here (spent 3min)

Reading src/main/java/org/cactoos/Input.java...
Puzzle 852-196f2f04 30/DEV at src/main/java/org/cactoos/Input.java
Reading src/main/java/org/cactoos/list/NoNulls.java...
Reading src/main/java/org/cactoos/list/ListIterator.java...
Reading src/main/java/org/cactoos/list/Sticky.java...
Reading src/main/java/org/cactoos/list/Joined.java...
Reading src/main/java/org/cactoos/list/ListEnvelope.java...
Reading src/main/java/org/cactoos/list/Sorted.java...
Reading src/main/java/org/cactoos/list/ListOf.java...
Reading src/main/java/org/cactoos/list/Solid.java...
Reading src/main/java/org/cactoos/list/package-info.java...
Reading src/main/java/org/cactoos/list/Mapped.java...
Reading src/main/java/org/cactoos/list/Synced.java...
Reading src/main/java/org/cactoos/list/Shuffled.java...
Reading src/main/java/org/cactoos/set/SetEnvelope.java...
Reading src/main/java/org/cactoos/set/package-info.java...
Puzzle 980-c8642680 30/DEV at src/main/java/org/cactoos/set/package-info.java
Reading src/main/java/org/cactoos/set/SetOf.java...
Reading src/main/java/org/cactoos/Scalar.java...
Reading src/verifier/verifications.xml...
Reading .gitlint...
Reading pom.xml...
Puzzle 903-fd48e847 30/DEV at pom.xml
Reading .gitattributes...
+ git log --not master --pretty=%B
+ gitlint
Traceback (most recent call last):
  File "/usr/local/bin/gitlint", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1037, in invoke
    return Command.invoke(self, ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/gitlint/cli.py", line 169, in cli
    ctx.invoke(lint)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/gitlint/cli.py", line 197, in lint
    gitcontext = GitContext.from_local_repository(lint_config.target, ctx.obj[2])
  File "/usr/local/lib/python2.7/dist-packages/gitlint/git.py", line 189, in from_local_repository
    raw_commit = _git("log", sha, "-1", long_format, _cwd=repository_path).split("\n")
  File "/usr/local/lib/python2.7/dist-packages/gitlint/git.py", line 33, in _git
    return ustr(result)
  File "/usr/local/lib/python2.7/dist-packages/gitlint/utils.py", line 18, in ustr
    return unicode(obj)  # pragma: no cover # noqa
  File "/usr/local/lib/python2.7/dist-packages/sh.py", line 593, in __unicode__
    self.call_args["decode_errors"])
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 9: ordinal not in range(128)
container 4a9aa285ada67a7e57338ba18668257983a134f022d6c88d99003695b70d54c5 is dead
Tue Jan 22 02:09:19 CET 2019

victornoel · 2019-01-22T14:21:49Z

@llorllale I suppose the above is not meant to happen?

llorllale · 2019-01-22T18:56:51Z

@victornoel no... have you tried running gitlint on your local?

victornoel · 2019-01-22T19:27:07Z

@llorllale the error above is not very clear, but on my local, I can see the actual error and it says I have to start the commit message with the issue number.

~~Are we seriously expecting people to start their commit with #, the character interpreted as a comment by the git when at the start of a line in a git message and thus ignoring the line?~~
~~It means we can't use an editor to set the git message, that sucks :)~~

Edit: I went too fast, actually the issue number must be inside parenthesis :)

victornoel · 2019-01-22T19:34:50Z

@llorllale I fixed the commit ;)

llorllale · 2019-01-23T00:27:53Z

@rultor merge

rultor · 2019-01-23T00:28:44Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-23T00:31:52Z

@rultor merge

@llorllale @victornoel Oops, I failed. You can see the full log here (spent 3min)

Reading src/main/java/org/cactoos/Input.java...
Puzzle 852-196f2f04 30/DEV at src/main/java/org/cactoos/Input.java
Reading src/main/java/org/cactoos/list/NoNulls.java...
Reading src/main/java/org/cactoos/list/ListIterator.java...
Reading src/main/java/org/cactoos/list/Sticky.java...
Reading src/main/java/org/cactoos/list/Joined.java...
Reading src/main/java/org/cactoos/list/ListEnvelope.java...
Reading src/main/java/org/cactoos/list/Sorted.java...
Reading src/main/java/org/cactoos/list/ListOf.java...
Reading src/main/java/org/cactoos/list/Solid.java...
Reading src/main/java/org/cactoos/list/package-info.java...
Reading src/main/java/org/cactoos/list/Mapped.java...
Reading src/main/java/org/cactoos/list/Synced.java...
Reading src/main/java/org/cactoos/list/Shuffled.java...
Reading src/main/java/org/cactoos/set/SetEnvelope.java...
Reading src/main/java/org/cactoos/set/package-info.java...
Puzzle 980-c8642680 30/DEV at src/main/java/org/cactoos/set/package-info.java
Reading src/main/java/org/cactoos/set/SetOf.java...
Reading src/main/java/org/cactoos/Scalar.java...
Reading src/verifier/verifications.xml...
Reading .gitlint...
Reading pom.xml...
Puzzle 903-fd48e847 30/DEV at pom.xml
Reading .gitattributes...
+ git log --not master --pretty=%B
+ gitlint
Traceback (most recent call last):
  File "/usr/local/bin/gitlint", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1037, in invoke
    return Command.invoke(self, ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/gitlint/cli.py", line 169, in cli
    ctx.invoke(lint)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/gitlint/cli.py", line 197, in lint
    gitcontext = GitContext.from_local_repository(lint_config.target, ctx.obj[2])
  File "/usr/local/lib/python2.7/dist-packages/gitlint/git.py", line 189, in from_local_repository
    raw_commit = _git("log", sha, "-1", long_format, _cwd=repository_path).split("\n")
  File "/usr/local/lib/python2.7/dist-packages/gitlint/git.py", line 33, in _git
    return ustr(result)
  File "/usr/local/lib/python2.7/dist-packages/gitlint/utils.py", line 18, in ustr
    return unicode(obj)  # pragma: no cover # noqa
  File "/usr/local/lib/python2.7/dist-packages/sh.py", line 593, in __unicode__
    self.call_args["decode_errors"])
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 9: ordinal not in range(128)
container 01fd00f8d398387e9d458c88f39704e98bfde787df605e4f3f1c4479f9400f7f is dead
Wed Jan 23 01:31:45 CET 2019

victornoel · 2019-01-23T10:33:15Z

@llorllale I don't understand what is the problem, it is as if there was some utf8 characters somewhere, but I can't reproduce on my machine… also it seems that travis does not exhibit the problem, only rultor…

llorllale · 2019-01-24T01:45:34Z

@rultor merge

rultor · 2019-01-24T01:46:12Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-24T01:59:55Z

@rultor merge

@llorllale Done! FYI, the full log is here (took me 14min)

0crat · 2019-01-24T02:22:03Z

The job #1029 is now out of scope

0crat · 2019-01-24T02:22:08Z

Order was finished: +15 point(s) just awarded to @fabriciofx /z

0crat · 2019-01-24T02:23:30Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale /z

victornoel mentioned this pull request Jan 20, 2019

UncheckedProc.java:35-37: Avoid usage of null value in... #885

Closed

0crat added the scope label Jan 20, 2019

fabriciofx reviewed Jan 20, 2019

View reviewed changes

victornoel force-pushed the 885-unchecked-proc-no-nulls branch 2 times, most recently from 748e123 to b1983cf Compare January 22, 2019 19:34

(yegor256#885) Remove references to null from UncheckedProc

9502abf

victornoel force-pushed the 885-unchecked-proc-no-nulls branch from b1983cf to 9502abf Compare January 23, 2019 07:57

llorllale mentioned this pull request Jan 24, 2019

Disable gitlint in .rultor #1041

Closed

rultor merged commit 9502abf into yegor256:master Jan 24, 2019

0crat removed the scope label Jan 24, 2019

llorllale mentioned this pull request Jan 27, 2019

Commit log linting not checking all PR commits #1045

Closed

victornoel deleted the 885-unchecked-proc-no-nulls branch February 15, 2020 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove nulls from UncheckedProc #885 #1029

Remove nulls from UncheckedProc #885 #1029

victornoel commented Jan 20, 2019

0crat commented Jan 20, 2019

codecov-io commented Jan 20, 2019 •

edited

Loading

0crat commented Jan 20, 2019

fabriciofx left a comment

fabriciofx Jan 20, 2019

victornoel Jan 20, 2019

fabriciofx Jan 20, 2019

llorllale Jan 20, 2019

victornoel Jan 21, 2019

fabriciofx commented Jan 20, 2019

fabriciofx commented Jan 20, 2019

rultor commented Jan 20, 2019

llorllale commented Jan 22, 2019

rultor commented Jan 22, 2019

rultor commented Jan 22, 2019

victornoel commented Jan 22, 2019

llorllale commented Jan 22, 2019

victornoel commented Jan 22, 2019 •

edited

Loading

victornoel commented Jan 22, 2019

llorllale commented Jan 23, 2019

rultor commented Jan 23, 2019

rultor commented Jan 23, 2019

victornoel commented Jan 23, 2019

llorllale commented Jan 24, 2019

rultor commented Jan 24, 2019

rultor commented Jan 24, 2019

0crat commented Jan 24, 2019

0crat commented Jan 24, 2019

0crat commented Jan 24, 2019

Remove nulls from UncheckedProc #885 #1029

Remove nulls from UncheckedProc #885 #1029

Conversation

victornoel commented Jan 20, 2019

0crat commented Jan 20, 2019

codecov-io commented Jan 20, 2019 • edited Loading

Codecov Report

0crat commented Jan 20, 2019

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx Jan 20, 2019

Choose a reason for hiding this comment

victornoel Jan 20, 2019

Choose a reason for hiding this comment

fabriciofx Jan 20, 2019

Choose a reason for hiding this comment

llorllale Jan 20, 2019

Choose a reason for hiding this comment

victornoel Jan 21, 2019

Choose a reason for hiding this comment

fabriciofx commented Jan 20, 2019

fabriciofx commented Jan 20, 2019

rultor commented Jan 20, 2019

llorllale commented Jan 22, 2019

rultor commented Jan 22, 2019

rultor commented Jan 22, 2019

victornoel commented Jan 22, 2019

llorllale commented Jan 22, 2019

victornoel commented Jan 22, 2019 • edited Loading

victornoel commented Jan 22, 2019

llorllale commented Jan 23, 2019

rultor commented Jan 23, 2019

rultor commented Jan 23, 2019

victornoel commented Jan 23, 2019

llorllale commented Jan 24, 2019

rultor commented Jan 24, 2019

rultor commented Jan 24, 2019

0crat commented Jan 24, 2019

0crat commented Jan 24, 2019

0crat commented Jan 24, 2019

codecov-io commented Jan 20, 2019 •

edited

Loading

victornoel commented Jan 22, 2019 •

edited

Loading