Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's remove non-decorator from list package #1413

Closed
victornoel opened this issue Jul 5, 2020 · 12 comments
Closed

Let's remove non-decorator from list package #1413

victornoel opened this issue Jul 5, 2020 · 12 comments

Comments

@victornoel
Copy link
Collaborator

In cactoos' collections classes, there is one one side iterable/iterator that provide iteration on collections of data, and on the other side the packages list, set, map and collection that concerns stateful data containers aka collections.

The current direction of Cactoos is to provide the maximum of functionality concerning iterable/iterator, and just the basic functionality concerning collections.

Let's remove from the list package the following classes: Sorted, Shuffled, Mapped.

Note that Joined will be transformed to a real lazy decorator in #1254. the map package will be taken care of via #1384, the set package is already ok and the collection package is just missing #1261.

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat assign @fabriciofx

@victornoel
Copy link
Collaborator Author

@fabriciofx I'm starting to assign manually because if not 0crat always assign latest issues and I would like to advance on those. I hope it's ok with you :) no rush anyway

@fabriciofx
Copy link
Contributor

@victornoel right, no problem! :)

@0crat
Copy link
Collaborator

0crat commented Sep 13, 2020

@0crat assign @fabriciofx (here)

@victornoel The job #1413 assigned to @fabriciofx/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@fabriciofx
Copy link
Contributor

@victornoel How about list.Synced? Should I keep it?

@victornoel
Copy link
Collaborator Author

@fabriciofx yes, we should keep it because its functionality cannot be provided just by delegating to one of the iterable decorator.

@victornoel victornoel added this to the 1.0 milestone Sep 13, 2020
@fabriciofx
Copy link
Contributor

@victornoel right! Thanks!

@fabriciofx
Copy link
Contributor

@victornoel Can you close this issue too?

@victornoel
Copy link
Collaborator Author

@fabriciofx yep, thx!

@0crat 0crat added the qa label Sep 17, 2020
@0crat
Copy link
Collaborator

0crat commented Sep 17, 2020

@sereshqua/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality good

@0crat 0crat added quality/good and removed qa labels Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants