Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1413: Let's remove non-decorator from list package #1456

Merged
merged 3 commits into from
Sep 13, 2020

Conversation

fabriciofx
Copy link
Contributor

Per #1413

  • Remove classes list.Sorted, list.Shuffled and list.Mapped
  • Remove repective tests classes

@codecov-commenter
Copy link

Codecov Report

Merging #1456 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1456      +/-   ##
============================================
- Coverage     89.94%   89.49%   -0.46%     
+ Complexity     1662     1644      -18     
============================================
  Files           280      277       -3     
  Lines          3980     3970      -10     
  Branches        210      210              
============================================
- Hits           3580     3553      -27     
- Misses          368      385      +17     
  Partials         32       32              
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/list/NoNulls.java 40.35% <0.00%> (-21.06%) 7.00% <0.00%> (-10.00%)
src/main/java/org/cactoos/collection/NoNulls.java 55.26% <0.00%> (-7.90%) 11.00% <0.00%> (-2.00%)
src/main/java/org/cactoos/list/ListIteratorOf.java 90.47% <0.00%> (-4.77%) 11.00% <0.00%> (-1.00%)
...ain/java/org/cactoos/list/ListIteratorNoNulls.java 80.95% <0.00%> (-4.77%) 8.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171c9ae...a3ed118. Read the comment docs.

Copy link
Contributor

@andreoss andreoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel Looks fine

@victornoel
Copy link
Collaborator

@andreoss thx, indeed nothing much to review there :)

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 13, 2020

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a3ed118 into yegor256:master Sep 13, 2020
@rultor
Copy link
Collaborator

rultor commented Sep 13, 2020

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

@0crat
Copy link
Collaborator

0crat commented Sep 13, 2020

Job was finished in 0 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Sep 13, 2020

Job audit: performer @andreoss/z/z didn't make CR comments

@0crat 0crat removed the 0crat/scope label Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants