Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputWithFallbackTest.readsAlternativeInputUri has an environmental dependency #537

Closed
llorllale opened this issue Jan 9, 2018 · 16 comments

Comments

@llorllale
Copy link
Contributor

This test depends on the environment on which it is being run. Where I am running this, we have a proxy that filters out certain sites and returns an HTTP OK response with a text that this test is not expecting, hence it fails.

To make it more consistent and predictable, and since the requirement (#255) is to capture any IOException, we could perhaps refactor like this:

    @Test
    public void readsAlternativeInputUri() {
        MatcherAssert.assertThat(
            "Can't read alternative source from URI",
            new TextOf(
                new InputWithFallback(
                    () -> { throw new IOException("Always fails!"); },
                    new InputOf("it works!")
                )
            ),
            new TextHasString(Matchers.endsWith("works!"))
        );
    }
@0crat
Copy link
Collaborator

0crat commented Jan 9, 2018

@yegor256 please, pay attention to this issue

@0crat 0crat removed their assignment Jan 10, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 10, 2018

Job #537 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 10, 2018

Bug was reported, see §29: +15 points just awarded to @llorllale, total is +15

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2018

The job #537 assigned to @Icok/z. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@0crat
Copy link
Collaborator

0crat commented Jan 22, 2018

@Icok/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2018

@Icok/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2018

The user @Icok/z resigned from #537, please stop working

@0crat
Copy link
Collaborator

0crat commented Jan 27, 2018

The job #537 assigned to @driver733/z. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@driver733
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

@0crat status (here)

@driver733 This is what I know about this job, as in §32:

  • The job #537 is in scope for 19days
  • The role is DEV
  • The job is assigned to @driver733/z for 2days
  • There is a monetary reward attached
  • @driver733/z will get 0.00 of their hourly rate for this job
  • The job doesn't have any impediments
  • The budget is 30 minutes
  • These users are banned and won't be assigned:

@driver733
Copy link
Contributor

@llorllale
@yegor256
This issue should be closed since the PR has been merged.

@driver733
Copy link
Contributor

@0crat waiting

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

@0crat waiting (here)

@driver733 The impediment for #537 was registered successfully by @driver733/z

@llorllale
Copy link
Contributor Author

@driver733 indeed, thank you

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Order was successfully finished: +30 points just awarded to @driver733/z, total is +60

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

The job #537 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants