Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#537 Refactored InputWithFallbackTest to always fallback to the specified fallback Input #583

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

driver733
Copy link
Contributor

As per #537

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2018

@yegor256/z please, pay attention to this pull request

@0crat 0crat added the scope label Jan 28, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 28, 2018

Job #583 is now in scope, role is REV

@codecov-io
Copy link

Codecov Report

Merging #583 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #583   +/-   ##
========================================
  Coverage      67.4%   67.4%           
  Complexity      994     994           
========================================
  Files           207     207           
  Lines          3436    3436           
  Branches        254     254           
========================================
  Hits           2316    2316           
  Misses         1049    1049           
  Partials         71      71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78950e6...c20e75e. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2018

This pull request #583 is assigned to @neonailol/z. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect.

@neonailol
Copy link
Contributor

@yegor256 good to merge

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 29, 2018

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c20e75e into yegor256:master Jan 29, 2018
@rultor
Copy link
Collaborator

rultor commented Jan 29, 2018

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Order was successfully finished: +15 points just awarded to @neonailol/z, total is +195

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Payment to ARC for a closed pull request, as in §28: +15 points just awarded to @yegor256/z, total is +8770

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

The job #583 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants