Enforce failure reasons in tests

[driver733]

I think that it would be great if we could enforce the usage of failure reasons in tests. If a test uses a test method that can have a failure reason and it does not use it, then the build should fail.

[0crat]

@yegor256/z please, pay attention to this issue

[yegor256]

@driver733 how is it technically possible?

[driver733]

@yegor256 We could, for instance, ban this method
<T> void assertThat(T actual, Matcher<? super T> matcher)
then, you would be directed to use one of these methods instead
<T> void assertThat(java.lang.String reason, boolean assertion)
<T> void assertThat(java.lang.String reason, T actual, Matcher<? super T> matcher)

We can extrapolate this logic on other test methods.

[yegor256]

@driver733 "ban" how?

[driver733]

@yegor256 Could we use Checkstyle's RegexpMultiline to create a custom checkstyle check for that?

[yegor256]

@driver733 I doubt it will work... can you try?

[driver733]

@yegor256 Sure, I will see what I can do.

[driver733]

@yegor256 Actually, we could use this

<module name="com.github.sevntu.checkstyle.checks.coding.ForbidCertainMethodCheck">
      <property name="methodName" value="assert(True|False)"/>
      <property name="argumentCount" value="1"/>
    </module>

[yegor256]

@driver733 yes, that will work, thanks

[0crat]

Job #704 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 points just awarded to @driver733/z, total is +335

[0crat]

The job #704 assigned to @flslkxtc/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

[smyachenkov]

@driver733 @yegor256 Cactoos project uses Qulice checkstyle rules, i think it more of a Qulice project issue than cactoos.

[0crat]

@flslkxtc/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[0crat]

The user @flslkxtc/z resigned from #704, please stop working. Reason for job resignation: It is older than 10 days, see §8

[0crat]

Resigned on delay, see §8: -30 points just awarded to @flslkxtc/z

[0crat]

The job #704 assigned to @neonailol/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

[neonailol]

@0crat waiting

[0crat]

There is an unrecoverable failure on my side. Please, submit it here:

com.amazonaws.http.AmazonHttpClient$RequestExecutor[1113] com.amazonaws.SdkClientException: Unable to execute HTTP request: null
sun.nio.ch.FileChannelImpl[110] java.nio.channels.ClosedChannelException: null

1.0-SNAPSHOT

[neonailol]

@0crat waiting

[0crat]

@0crat waiting (here)

@neonailol The impediment for #704 was registered successfully by @neonailol/z

[llorllale]

@neonailol are you working on this? I know that PR #702 was merged, but it doesn't really address this requirement

[llorllale]

@neonailol ping

[llorllale]

@neonailol ping

[neonailol]

@llorllale pr was declined to merge with inconvenient reason, so this task is open

[llorllale]

@neonailol are you still interested in completing this task?

[neonailol]

@llorllale yes, but I don't think that suggested solution #744 (comment) is a good one

[llorllale]

@neonailol please move forward with this task

[neonailol]

@llorllale submitted #899

[llorllale]

@driver733 this was implemented in PR #899

[0crat]

Job #704 is not in the agenda of @neonailol/z, can't retrieve data and time of add

[0crat]

The project doesn't have enough funds, can't make a payment

[0crat]

The job #704 is now out of scope

[0crat]

Order was finished: +30 point(s) just awarded to @neonailol/z