Tests don't remove temporary files (if created)

[proshin-roman]

Currently, no tests in the project care about removing temporary files. As an example, see this class:

cactoos/src/test/java/org/cactoos/io/WriterAsOutputTest.java

Line 59 in c235a77

new FileOutputStream(temp.toFile()),

It means all temporary files stay forever in the OS temp directory until OS removes them itself.

How it should be done:

• tests should either call method deleteOnExit for each temp file or should delete temp file manually

[0crat]

@yegor256/z please, pay attention to this issue

[yegor256]

@proshin-roman definitely a bug, thanks for reporting

[0crat]

Job #702 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 points just awarded to @proshin-roman/z, total is +15

[msarhan]

Using JUnit's TemporaryFolder Rule instead of Files.createTempFile() will solve the issue.

[proshin-roman]

@msarhan good idea! I've already applied it in two my pull requests: #698 and #676

[0crat]

The job #702 assigned to @flslkxtc/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

[smyachenkov]

@0crat waiting

[0crat]

@0crat waiting (here)

@flslkxtc The impediment for #702 was registered successfully by @flslkxtc/z

[llorllale]

@0crat resign @flslkxtc

[0crat]

@0crat resign @flslkxtc (here)

@llorllale The user @flslkxtc/z resigned from #702, please stop working. Reason for job resignation: Order was cancelled

[llorllale]

@flslkxtc you were resigned because you're currently on vacation

[0crat]

The job #702 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

[krzyk]

@proshin-roman please see PR #779

[proshin-roman]

@krzyk The pull request looks ok for me but you have to wait until it's reviewed by the assigned reviewer.

[0crat]

@krzyk/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[krzyk]

@0crat waiting for review

[0crat]

@0crat waiting for review (here)

@krzyk The impediment for #702 was registered successfully by @krzyk/z

[krzyk]

@proshin-roman please close this issue, fix has been merged to master

[0crat]

@elenavolokhova/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #702 is now out of scope

[elenavolokhova]

@0crat quality good

[0crat]

Order was finished, quality is "good": +35 point(s) just awarded to @krzyk/z

[0crat]

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z