-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matcher ScalarHasValue has to override describeMismatchSafely for better output #816
Comments
@llorllale/z please, pay attention to this issue |
@proshin-roman let's put this on hold while #751 is sorted out |
@llorllale yeah, ok, let's wait |
@proshin-roman matchers were moved to |
There is an unrecoverable failure on my side. Please, submit it here:
1.0-SNAPSHOT: CID: 1321938267, Type: 'Close job', Author: llorllale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
ScalarHasValue
doesn't override methoddescribeMismatchSafely
that leads to the next problem:so it prints an actual version incorrectly: default toString method is called for the Scalar.
Expected:
What should be fixed
ScalarHasValue
has to override methoddescribeMismatchSafely
and convert Scalar to String properly.The text was updated successfully, but these errors were encountered: