Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncFunc.java:48-52: Avoid usage of null value in... #884

Closed
0pdd opened this issue May 19, 2018 · 29 comments
Closed

AsyncFunc.java:48-52: Avoid usage of null value in... #884

0pdd opened this issue May 19, 2018 · 29 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented May 19, 2018

The puzzle 861-7a51e9e5 from #861 has to be resolved:

* @todo #861:30min Avoid usage of null value in ctor(Proc, ExecutorService),
* ctor(Proc, ThreadFactory) and ctor(Proc) which is against design
* principles.
* Perhaps with a creation of AsyncProc or removal of this functionality?
* Please take a look on #551 and #843 for more details.

The puzzle was created by Isammoc OFF on 16-May-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented May 19, 2018

@llorllale/z please, pay attention to this issue

@0crat 0crat added the scope label May 19, 2018
@0crat
Copy link
Collaborator

0crat commented May 19, 2018

Job #884 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jun 29, 2018

The job #884 assigned to @jsoroka/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 4, 2018

@jsoroka/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

The job #884 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@ammaratef45
Copy link

@llorllale
I noticed that the name of the class changed from AsyncFunc to Async,
I see in #551 @SharplEr made another FunOf that doesn't take a result as a parameter, why this solution isn't there? I see it was accepted by the reviewer at the end

@llorllale
Copy link
Contributor

@ammaratef45 provide link please

@ammaratef45
Copy link

@llorllale
SharplEr@1f687cf
This is one of his commits,
The whole discussion is at #551 too

@llorllale
Copy link
Contributor

@ammaratef45 he left a puzzle precisely to remove that ctor in a later PR

@ammaratef45
Copy link

@llorllale Yes, but his code isn't I the master branch, should I switch to another branch or reimplement his changes?

@ammaratef45
Copy link

@llorllale @0crat
waiting for clarification

@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

@ammaratef45
Copy link

@0crat waiting

@0crat
Copy link
Collaborator

0crat commented Jan 4, 2019

@0crat waiting (here)

@ammaratef45 Job #884 is not assigned, can't put it on hold

@llorllale
Copy link
Contributor

@ammaratef45 what code is it that you're not seeing in the master branch? The PR you referenced to earlier was merged [to the master branch].

@g4s8
Copy link
Contributor

g4s8 commented Jan 6, 2019

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jan 6, 2019

@0crat status (here)

@g4s8 This is what I know about this job in C63314D6Z, as in §32:

  • The job #884 is in scope for 8mon
  • The role is DEV
  • The job is not assigned to anyone
  • The budget is not set yet
  • These users are banned and won't be assigned:
  • Job footprint (restricted area)

@0crat
Copy link
Collaborator

0crat commented Jan 7, 2019

The job #884 assigned to @marceloamadeu/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@marceloamadeu
Copy link
Contributor

@0crat wait

@0crat
Copy link
Collaborator

0crat commented Jan 18, 2019

@0crat wait (here)

@marceloamadeu Job #884 is already on hold

@marceloamadeu
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Feb 4, 2019

@0crat refuse (here)

@marceloamadeu The user @marceloamadeu/z resigned from #884, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Feb 4, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @marceloamadeu/z

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2019

The job #884 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator

@0crat waiting for #1068 to be merged

@0crat
Copy link
Collaborator

0crat commented Feb 9, 2019

@0crat waiting for #1068 to be merged (here)

@victornoel The impediment for #884 was registered successfully by @victornoel/z

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 26, 2019

The puzzle 861-7a51e9e5 has disappeared from the source code, that's why I closed this issue.

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2019

The job #884 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2019

Order was finished: +30 point(s) just awarded to @victornoel/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants