-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#884) Remove nulls from Async class #1068
Conversation
Job #1068 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
============================================
- Coverage 87.63% 87.61% -0.02%
+ Complexity 1529 1526 -3
============================================
Files 269 269
Lines 3929 3923 -6
Branches 215 215
============================================
- Hits 3443 3437 -6
Misses 437 437
Partials 49 49
Continue to review full report at Codecov.
|
This pull request #1068 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@llorllale REV seems not be responding, anyway to get someone else or a review? :) |
@0crat refuse |
@llorllale The user @fabriciofx/z resigned from #1068, please stop working. Reason for job resignation: Order was cancelled |
This pull request #1068 is assigned to @iprogrammerr/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@victornoel I can not find anything wrong here. |
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 13min) |
Quality is low, no payment, see §31: |
The job #1068 is now out of scope |
Payment to |
#884 : this removes null from
Async
and also update tests to illustrate its usage withProc
andFuncOf
(as proposed by ARC here: #551 (comment)).I also updated the rests to use
Assertion
while I was at it