Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#884) Remove nulls from Async class #1068

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

victornoel
Copy link
Collaborator

@victornoel victornoel commented Feb 9, 2019

#884 : this removes null from Async and also update tests to illustrate its usage with Proc and FuncOf (as proposed by ARC here: #551 (comment)).

I also updated the rests to use Assertion while I was at it

@0crat
Copy link
Collaborator

0crat commented Feb 9, 2019

Job #1068 is now in scope, role is REV

@codecov-io
Copy link

Codecov Report

Merging #1068 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1068      +/-   ##
============================================
- Coverage     87.63%   87.61%   -0.02%     
+ Complexity     1529     1526       -3     
============================================
  Files           269      269              
  Lines          3929     3923       -6     
  Branches        215      215              
============================================
- Hits           3443     3437       -6     
  Misses          437      437              
  Partials         49       49
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/func/Async.java 100% <ø> (ø) 6 <0> (-3) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da3c4e0...ee97241. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Feb 9, 2019

This pull request #1068 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator Author

@llorllale REV seems not be responding, anyway to get someone else or a review? :)

@llorllale
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Feb 23, 2019

@0crat refuse (here)

@llorllale The user @fabriciofx/z resigned from #1068, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Feb 23, 2019

This pull request #1068 is assigned to @iprogrammerr/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@BinaryIgor
Copy link
Contributor

@victornoel I can not find anything wrong here.
@llorllale Good to merge.

@llorllale
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 26, 2019

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit ee97241 into yegor256:master Feb 26, 2019
@rultor
Copy link
Collaborator

rultor commented Feb 26, 2019

@rultor merge

@llorllale Done! FYI, the full log is here (took me 13min)

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2019

Quality is low, no payment, see §31:

@0crat 0crat removed the scope label Feb 26, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 26, 2019

The job #1068 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

@victornoel victornoel deleted the 884-asyncfunc-no-nulls branch February 15, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants