Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-info.java:38-41: Continue applying the new class... #980

Closed
0pdd opened this issue Dec 20, 2018 · 22 comments
Closed

package-info.java:38-41: Continue applying the new class... #980

0pdd opened this issue Dec 20, 2018 · 22 comments
Milestone

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 20, 2018

The puzzle 964-1a0e1078 from #964 has to be resolved:

* @todo #964:30min Continue applying the new class naming convention in effect:
* avoid compound names for decorators. Continue renaming classes according to
* this table: https://github.com/yegor256/cactoos/issues/913#issuecomment-402332247.
* Remaining packages are scalar, set, text, and time.

The puzzle was created by George Aristy on 20-Dec-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Dec 20, 2018

This puzzle inherited milestone 1.0 from issue #964.

@0crat
Copy link
Collaborator

0crat commented Dec 20, 2018

@llorllale/z please, pay attention to this issue

@0crat 0crat added the scope label Dec 20, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 20, 2018

Job #980 is now in scope, role is DEV

@llorllale llorllale added this to the 1.0 milestone Dec 20, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

The job #980 assigned to @dgroup/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Job gh:yegor256/cactoos#980 already assigned to @dgroup, can't assign to @dgroup

@dgroup
Copy link
Contributor

dgroup commented Jan 5, 2019

@0crat wait as clarification is required for this task.

@0crat
Copy link
Collaborator

0crat commented Jan 5, 2019

@0crat wait as clarification is required for this task. (here)

@dgroup The impediment for #980 was registered successfully by @dgroup/z

@dgroup
Copy link
Contributor

dgroup commented Jan 5, 2019

@llorllale, as i understood we need to rename the classes from the following packages in order to avoid compound names:

  • scalar
  • set
  • text
  • time

Do we need to rename the *Envelope classes?

Also, as far as I can see there are a lot of implementations of Bytes present in *.io package and has the same problem like CheckedBytes, UncheckedBytes, etc.
What should be done with them?

I would like to highlight that in order to avoid the compound names all implementations of Input, Output, Bytes, Func, BiFunc, Proc, BiProc, Scalar, Text should have their own packages.
Now, the some of implementation of Bytes, Input, Output shuffled between packages org.cactoos.io, org.cactoos.bytes.
We can fix that by changing our packages structure to

org.cactoos.io
|- bytes
|- input
|- output

Similar situation with Func, BiProc and BiFunc.

@llorllale
Copy link
Contributor

@dgroup

Also, as far as I can see there are a lot of implementations of Bytes present in *.io package and has the same problem like CheckedBytes, UncheckedBytes, etc.
What should be done with them?

The general rule is to avoid compound names, yes, but sometimes technical limitations force us to keep using them in some cases. For example, there are more than one classes with the Checked prefix in their names in the io package. Removing the suffix would create a naming conflict. If you see any remaining classes in the io package or anywhere else with compound names that can be simplified without causing conflicts, please go ahead and refactor.

Do we need to rename the *Envelope classes?

I don't think we need to rename the *Envelopes. It's a special naming convention that communicates something about those classes.

I would like to highlight that in order to avoid the compound names all implementations of Input, Output, Bytes, Func, BiFunc, Proc, BiProc, Scalar, Text should have their own packages.

I'm not convinced it's worth it. Would be better to discuss in a separate ticket.

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 14, 2019

The puzzle 964-1a0e1078 has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 14, 2019

@0pdd 5 puzzles #1003, #1004, #1005, #1006, #1007 are still not solved.

@0crat 0crat removed the scope label Jan 14, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

The job #980 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

Order was finished: +30 point(s) just awarded to @dgroup/z

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 18, 2019

@0pdd 4 puzzles #1003, #1005, #1006, #1007 are still not solved; solved: #1004.

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 19, 2019

@0pdd 4 puzzles #1003, #1005, #1006, #1025 are still not solved; solved: #1004, #1007.

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 27, 2019

@0pdd 4 puzzles #1003, #1005, #1025, #1046 are still not solved; solved: #1004, #1006, #1007.

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 7, 2019

@0pdd 5 puzzles #1003, #1025, #1046, #1064, #1065 are still not solved; solved: #1004, #1005, #1006, #1007.

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 26, 2019

@0pdd 5 puzzles #1003, #1025, #1046, #1064, #1074 are still not solved; solved: #1004, #1005, #1006, #1007, #1065.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 10, 2019

@0pdd 4 puzzles #1003, #1025, #1046, #1074 are still not solved; solved: #1004, #1005, #1006, #1007, #1064, #1065.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 17, 2019

@0pdd 3 puzzles #1003, #1025, #1046 are still not solved; solved: #1004, #1005, #1006, #1007, #1064, #1065, #1074.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 23, 2019

@0pdd the puzzle #1046 is still not solved; solved: #1003, #1004, #1005, #1006, #1007, #1025, #1064, #1065, #1074.

@0pdd
Copy link
Collaborator Author

0pdd commented May 10, 2019

@0pdd all 10 puzzles are solved here: #1003, #1004, #1005, #1006, #1007, #1025, #1046, #1064, #1065, #1074.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants