Removed nulls from Retry (#886) #1010
Conversation
|
Job #1010 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
============================================
- Coverage 87.65% 87.58% -0.08%
+ Complexity 1524 1520 -4
============================================
Files 267 267
Lines 3903 3897 -6
Branches 215 215
============================================
- Hits 3421 3413 -8
- Misses 433 435 +2
Partials 49 49
Continue to review full report at Codecov.
|
|
This pull request #1010 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
|
@victornoel Ping. |
| @@ -35,6 +35,11 @@ | |||
| * @param <X> Type of input | |||
| * @param <Y> Type of input | |||
| * @since 0.22 | |||
| * @todo #861:30min Avoid usage of null value in exec(first, second), | |||
There was a problem hiding this comment.
@Iprogrammerr the issue number should refer to the bug you are solving
| }, | ||
| count -> count == Integer.MAX_VALUE | ||
| ).apply(true), | ||
| Matchers.nullValue() | ||
| Matchers.equalTo(true) |
There was a problem hiding this comment.
@Iprogrammerr please use FuncApplies instead of EqualTo and Assertion instead of assertThat from cactoos-matchers
There was a problem hiding this comment.
@victornoel We need to wait for #1023 to do that.
|
@victornoel Ping. |
|
@Iprogrammerr thx |
|
@llorllale ping |
|
@llorllale still good to merge ;) |
|
@Iprogrammerr can you please rebase on |
BinaryIgor
force-pushed
the
886
branch
2 times, most recently
from
de50fbf
to
6c52c94
Compare
|
@llorllale Done. |
|
@Iprogrammerr I get the feeling that |
|
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 12min) |
|
Code review was too long (18 days), architects (@llorllale) were penalized, see §55 |
|
The job #1010 is now out of scope |
|
Order was finished: +15 point(s) just awarded to @victornoel/z |
|
Payment to |
Solving #886 puzzle. According to recommendations by ARC (#918 (comment)), I simply removed the constructors using null and taking a Proc. Tests were modified as needed.