#702 Remove temporary files in tests #728
Conversation
|
Job #728 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
============================================
- Coverage 75.79% 75.73% -0.06%
+ Complexity 1124 1123 -1
============================================
Files 222 222
Lines 3342 3342
Branches 189 189
============================================
- Hits 2533 2531 -2
- Misses 762 764 +2
Partials 47 47
Continue to review full report at Codecov.
|
|
@neonailol rultor was down, can you trigger it once more? |
|
@rultor good to merge |
@neonailol Thanks for your request. @yegor256 Please confirm this. |
|
@neonailol/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
|
@yegor256 Please confirm this. |
|
@neonailol/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
|
The user @neonailol/z resigned from #728, please stop working. Reason for job resignation: It is older than 10 days, see §8 |
|
Resigned on delay, see §8: -15 points just awarded to @neonailol/z |
|
The user @fabriciofx/z resigned from #728, please stop working. Reason for job resignation: It is older than 10 days, see §8 |
|
Resigned on delay, see §8: -15 point(s) just awarded to @fabriciofx/z |
|
This pull request #728 is assigned to @krzyk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer |
|
@flslkxtc please see my comments |
|
@llorllale PR author is on vacation, so he won't be able to fix issues here. And because we don't know how long the vacation will take, so I'm rejecting this PR and propose to assign the #702 to someone else (having a PRs and issues opened for long time is bad for the project). |
|
@krzyk where are your comments for this PR? |
| * Temporary files generator. | ||
| */ | ||
| @Rule | ||
| public TemporaryFolder folder = new TemporaryFolder(); |
| * Temporary files generator. | ||
| */ | ||
| @Rule | ||
| public TemporaryFolder folder = new TemporaryFolder(); |
| * Temporary files generator. | ||
| */ | ||
| @Rule | ||
| public TemporaryFolder folder = new TemporaryFolder(); |
There was a problem hiding this comment.
@flslkxtc Why not final?
And same for all other instances of TemporaryFolder.
|
@llorllale Oops, sorry for that (github changed the file review process since I used it last time). I've submitted the the review comments now. I'll wait for @flslkxtc reply. |
|
@krzyk I agree to close this PR |
|
@elenavolokhova/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #728 is now out of scope |
|
Payment to |
|
@0crat quality acceptable |
|
Quality review completed: +8 point(s) just awarded to @elenavolokhova/z |
Issue #702.
Replace Files#createTempFile with TemporaryFolder to ensure that all temporary files will be removed after unit tests are complete.