Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static inner classes should be qualified with outer class always #738

Closed
krzyk opened this issue Feb 28, 2016 · 27 comments
Closed

Static inner classes should be qualified with outer class always #738

krzyk opened this issue Feb 28, 2016 · 27 comments

Comments

@krzyk
Copy link
Collaborator

krzyk commented Feb 28, 2016

Static inner classes declared in given class and used in it should be qualified if the class name.

Right now qulice doesn't complain about such cases, but it should:

public class Foo {

    public void method(int num) {
        new Bar(num);
    }

    private static final class Bar {
        private final num;

        Bar(int num) {
            this.num = num;
        }
    }
}

Qulice should complain in method() line with new Bar(num) that the inner class should be qualified with outer class name.

method() should look like this:

    public void method(int num) {
        new Foo.Bar(num);
    }
@krzyk
Copy link
Collaborator Author

krzyk commented Feb 28, 2016

@davvd valid bug

@davvd
Copy link

davvd commented Feb 29, 2016

@davvd valid bug

@krzyk I tagged this as "bug"

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 9, 2016

@davvd this is postponed

@davvd
Copy link

davvd commented Mar 10, 2016

@davvd this is postponed

@krzyk got it, "postponed" label here

@davvd
Copy link

davvd commented Mar 10, 2016

@davvd this is postponed

@krzyk right, I will find someone else, no problem

@davvd
Copy link

davvd commented Mar 11, 2016

@krzyk thanks a lot for reporting, 30 mins added to your acc, pmt ID 80002206

@krzyk
Copy link
Collaborator Author

krzyk commented May 1, 2018

@0crat in

@0crat 0crat added the scope label May 1, 2018
@0crat
Copy link
Collaborator

0crat commented May 1, 2018

@0crat in (here)

@krzyk Job #738 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 1, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented May 1, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 7, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 12, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 17, 2018

@krzyk/z everybody who has role DEV are banned at #738; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 22, 2018

@krzyk/z everybody who has role DEV is banned at #738; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 27, 2018

@krzyk/z everybody who has role DEV is banned at #738; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2018

@krzyk/z everybody who has role DEV is banned at #738; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2018

@krzyk/z everybody who has role DEV is banned at #738; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 11, 2018

@krzyk/z everybody who has role DEV is banned at #738; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 18, 2019
paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 24, 2019
paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 24, 2019
@0pdd
Copy link
Collaborator

0pdd commented Jan 24, 2019

@krzyk the puzzle #1008 is still not solved.

@paulodamaso
Copy link
Contributor

@krzyk Merged, please close.

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 24, 2019

@paulodamaso thanks

@krzyk krzyk closed this as completed Jan 24, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jan 24, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

The job #738 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants