Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #738: Qulaify inner classes #987

Merged
merged 4 commits into from
Jan 24, 2019
Merged

For #738: Qulaify inner classes #987

merged 4 commits into from
Jan 24, 2019

Conversation

paulodamaso
Copy link
Contributor

For #738: Qulaify inner classes

  • Addes test to ensure that inner classes are being accessed through qualified name
  • Left puzzle for check implementatio

@0crat 0crat added the scope label Jan 18, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 18, 2019

Job #987 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jan 18, 2019

@krzyk/z everybody who has role REV is banned at #987; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@paulodamaso
Copy link
Contributor Author

@krzyk ping

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2019

@krzyk/z everybody who has role REV is banned at #987; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator

krzyk commented Jan 23, 2019

@paulodamaso one comment, and make sure to update the copyright years

@paulodamaso
Copy link
Contributor Author

@krzyk Which comment?

* Checks if inner classes are properly accessed using their qualified name
* with the outer class.
*
* @since 0.19.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso maybe let's use since 0.18, without the patch versions

@krzyk
Copy link
Collaborator

krzyk commented Jan 24, 2019

@paulodamaso now it is visible :)

@paulodamaso
Copy link
Contributor Author

@krzyk Thanks done the correction please take a look

@krzyk
Copy link
Collaborator

krzyk commented Jan 24, 2019

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 24, 2019

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b2e8fd5 into yegor256:master Jan 24, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 24, 2019

@rultor merge

@krzyk Done! FYI, the full log is here (took me 22min)

@0crat 0crat removed the scope label Jan 24, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

Job gh:teamed/qulice#987 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 24, 2019

The job #987 is now out of scope

@paulodamaso paulodamaso deleted the 738 branch January 24, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants