Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using keys of ArrayCache.php #19913

Closed
wants to merge 1 commit into from
Closed

Fix using keys of ArrayCache.php #19913

wants to merge 1 commit into from

Conversation

AVZaitsev
Copy link

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Jul 26, 2023

PR Summary

  • Enhanced Access to Cache Array
    The developer added an additional step to generate a unique identifier (known as a key) before an item is inserted, retrieved, or deleted from the memory storage system (cache) in the programming file named ArrayCache.php. This helps in efficiently managing the data stored in the cache, making it easier to locate and manipulate specific information. It's similar to how a librarian would first reference a library card catalogue before finding the exact book on the shelf.

@AVZaitsev AVZaitsev changed the title Fix A ArrayCache.php Fix using keys of ArrayCache.php Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c8c0ea9) 48.89% compared to head (2f32981) 48.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19913   +/-   ##
=======================================
  Coverage   48.89%   48.89%           
=======================================
  Files         445      445           
  Lines       42786    42790    +4     
=======================================
+ Hits        20919    20923    +4     
  Misses      21867    21867           
Files Changed Coverage Δ
framework/caching/ArrayCache.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rob006
Copy link
Contributor

rob006 commented Jul 26, 2023

buildKey() is already called before passing key to these methods:

$key = $this->buildKey($key);
$value = $this->getValue($key);

@AVZaitsev AVZaitsev closed this by deleting the head repository Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants