Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using keys of ArrayCache.php #19913

Closed
wants to merge 1 commit into from
Closed

Fix using keys of ArrayCache.php #19913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions framework/caching/ArrayCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
*/
protected function getValue($key)
{
$key = $this->buildKey($key);
if (isset($this->_cache[$key]) && ($this->_cache[$key][1] === 0 || $this->_cache[$key][1] > microtime(true))) {
return $this->_cache[$key][0];
}
Expand All @@ -53,6 +54,7 @@
*/
protected function setValue($key, $value, $duration)
{
$key = $this->buildKey($key);
$this->_cache[$key] = [$value, $duration === 0 ? 0 : microtime(true) + $duration];
return true;
}
Expand All @@ -62,6 +64,7 @@
*/
protected function addValue($key, $value, $duration)
{
$key = $this->buildKey($key);

Check warning on line 67 in framework/caching/ArrayCache.php

View check run for this annotation

Codecov / codecov/patch

framework/caching/ArrayCache.php#L67 

Added line #L67 was not covered by tests
if (isset($this->_cache[$key]) && ($this->_cache[$key][1] === 0 || $this->_cache[$key][1] > microtime(true))) {
return false;
}
Expand All @@ -74,6 +77,7 @@
*/
protected function deleteValue($key)
{
$key = $this->buildKey($key);
unset($this->_cache[$key]);
return true;
}
Expand Down
Loading