Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper text when search with no dictionaries enabled #1220

Merged
merged 6 commits into from
Jul 14, 2024
Merged

Add helper text when search with no dictionaries enabled #1220

merged 6 commits into from
Jul 14, 2024

Conversation

khaitruong922
Copy link

#1029

  • When user searches without a dictionary enabled on Search page, it will show a helper message and a hyperlink to the Dictionaries section in the Settings page.

@khaitruong922 khaitruong922 requested a review from a team as a code owner July 13, 2024 17:16
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Jul 13, 2024
jamesmaa
jamesmaa reviewed Jul 14, 2024
View reviewed changes
ext/popup.html Outdated Show resolved Hide resolved
@jamesmaa jamesmaa added this pull request to the merge queue Jul 14, 2024
Merged via the queue into yomidevs:master with commit 18149b6 Jul 14, 2024
11 checks passed
@jamesmaa jamesmaa mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmaa jamesmaa jamesmaa approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaitruong922 @jamesmaa @Kuuuube