Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when editing Tree due to missing insPrevID in CRDTTree #153

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Mar 13, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 1.12994% with 175 lines in your changes are missing coverage. Please review.

Project coverage is 41.96%. Comparing base (2dee076) to head (64c116e).

Files Patch % Lines
Tests/Integration/TreeIntegrationTests.swift 0.00% 175 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   42.25%   41.96%   -0.30%     
==========================================
  Files         104      104              
  Lines       24389    24566     +177     
==========================================
+ Hits        10306    10308       +2     
- Misses      14083    14258     +175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit 04aa818 into main Mar 13, 2024
2 of 3 checks passed
@humdrum humdrum deleted the fix-missing-insprevid branch March 13, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants