Fix errors when editing Tree due to missing insPrevID in CRDTTree #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 81.50% 81.67% +0.16%
==========================================
Files 59 59
Lines 4348 4350 +2
Branches 853 853
==========================================
+ Hits 3544 3553 +9
+ Misses 543 539 -4
+ Partials 261 258 -3 ☔ View full report in Codecov by Sentry. |
chacha912
approved these changes
Feb 26, 2024
hackerwins
pushed a commit
that referenced
this pull request
Mar 5, 2024
When performing `CRDTTree.edit()`, the edits are reflected by deepcopying the CRDTTreeNodes for the given range. This commit adds information about `insPrevID` and `insNextID` during the `deepcopy()` process to ensure that the correct location is returned from the correct path. --------- Co-authored-by: Yourim Cha <[email protected]>
2 tasks
2 tasks
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR aims to resolve the issue of incorrect index calculation during tree edit when editing copy nodes, due to the missing
insPrevIDinformation in thedeepcopy()process. By adding this information, the problem can be fixed.Any background context you want to provide?
The process of creating a document from a snapshot works fine(link). However, the issue arises when editing copy nodes during the editing process, as the
insPrevIDinformation is not copied during thedeepcopy()process. This omission leads to incorrect index calculation. To address this, relevant modifications have been implemented in the code.What are the relevant tickets?
Address #754
Checklist