Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
install.sh
script can be used to install the binary into/usr/bin
. This script is really optimistic so this MRadds at least two error checks:
rm -rf
on something that may not be the expected temporary directory may lead to unexpected and dangerous results/usr/bin
and a normal user will not be able to do that. So theinstall.sh
script performs the move withsudo
. This assume thatsudo
is available on the system and the user actually has the necessary rights to perform the move. We now check the return value of the move instead.