Add error handling in install.sh #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `install.sh` script should have the executable bit set in order to be able to run `./install.sh` from the source directory.
The script install.sh creates a temporary directory in order to download and extract files. We should validate this succeeds otherwise all following steps can lead to strange results. Especially since we run `rm -rf` on the temp directory we should ensure we actually got a temporary directory and are not removing something unrelated.
The install.sh script moves the downloaded and extracted binary to `/usr/bin`. This may fail for different reasons, e.g. - `sudo` may not be available on the system at all - the current user has no sudo permissions to move the file Before this change we still saw a success message. We should check if the move actually succeeded.
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
install.shscript can be used to install the binary into/usr/bin. This script is really optimistic so this MRadds at least two error checks:
rm -rfon something that may not be the expected temporary directory may lead to unexpected and dangerous results/usr/binand a normal user will not be able to do that. So theinstall.shscript performs the move withsudo. This assume thatsudois available on the system and the user actually has the necessary rights to perform the move. We now check the return value of the move instead.