Add error handling in install.sh #119
Merged
Commits on May 11, 2024
-
maint: Ensure install.sh is executable
The `install.sh` script should have the executable bit set in order to be able to run `./install.sh` from the source directory.
-
Validate creation of temporary directory in install.sh
The script install.sh creates a temporary directory in order to download and extract files. We should validate this succeeds otherwise all following steps can lead to strange results. Especially since we run `rm -rf` on the temp directory we should ensure we actually got a temporary directory and are not removing something unrelated.
-
-
Validate successfull installation in install.sh
The install.sh script moves the downloaded and extracted binary to `/usr/bin`. This may fail for different reasons, e.g. - `sudo` may not be available on the system at all - the current user has no sudo permissions to move the file Before this change we still saw a success message. We should check if the move actually succeeded.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.