Ignore links with specific data attribute in href() listener

[jliuhtonen]

Like described in issue #15, it is sometimes necessary to create links that are not handled with the SPA router, like paths that are handled by an external 3rd party system.

This PR implements ignoring specified links by adding data-no-routing attribute to the <a> element. Because of compatibility reasons there are two ways of using this, data-no-routing (boolean attribute) or data-no-routing="true" (string attribute, the value can be anything).

[jliuhtonen]

Added a fix for issue where secondary mouse button clicks were captured and key combinations, like cmd-clicking on a mac, did not work as expected.

[yoshuawuyts]

This looks good to me! - I reckon we ought to have tests for this though; would you be willing to add those for the href file, perhaps in a separate patch? - heaps thanks for taking your time to submit this, apologies I didn't get around to merging this sooner!

[yoshuawuyts]

I released this as 3.2.0 and then had to unrelease again because accidental changes were pulled in. Oops, apologies! haha

[jliuhtonen]

Thanks! I agree that this functionality should have tests. I'm interested
in implementing them, so I'll give it a shot when I have time.

On Thursday, 18 August 2016, Yoshua Wuyts [email protected] wrote:

This looks good to me! - I reckon we ought to have tests for this though;
would you be willing to add those for the href file, perhaps in a
separate patch? - heaps thanks for taking your time to submit this,
apologies I didn't get around to merging this sooner!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-aTXTcpIeW3j5C-lUM81pyHqepkRPrks5qhF9agaJpZM4JI3xw
.