added tests and root functionality #49
Conversation
| @@ -9,14 +9,14 @@ const noRoutingAttrName = 'data-no-routing' | |||
| // and url lives on the same domain. Replaces | |||
| // trailing '#' so empty links work as expected. | |||
| // fn(str) -> null | |||
There was a problem hiding this comment.
could you change the signature to be:
// (fn(str), obj?) -> nullthanks!
There was a problem hiding this comment.
Whoops, sorry, good catch! Fixing!
|
sweet, thanks! |
|
Gah, apparently forgot to use my brain in that first comment signature fix. Should be better now. :P |
|
Btw, to be exact, the function returns In addition to the tests in place, I think 👍 |
|
Whoops again, good catch @jliuhtonen. Agreed on unit tests alone not really feeling sufficient here. Also agreed on dealing with that later. :) |
| @@ -8,15 +8,15 @@ const noRoutingAttrName = 'data-no-routing' | |||
| // handle a click if is anchor tag with an href | |||
| // and url lives on the same domain. Replaces | |||
| // trailing '#' so empty links work as expected. | |||
| // fn(str) -> null | |||
| function href (cb) { | |||
| // (fn(str), obj?) -> undefined | |||
There was a problem hiding this comment.
could you leave this as null? thanks - I know it's only a convention and not enforced so I know it's a bit silly but yeah I use null like C's void return. Thank you!
|
Thanks! I'll publish this at a later time as master isn't published yet. Cheers! |
This PR extends the signature of
hreftohref(cb, root), whererootis an optional dom node that we will never capture clicks outside of.When adding tests for this I also added missing test for the basic
hreffunctionality, including the data attribute thing that @jliuhtonen implemented in #27.