Pin proj to 7.x per SciTools/cartopy#1140 #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
added
bug
infrastructure
munkm
approved these changes
May 24, 2021
cphyc
approved these changes
May 24, 2021
|
I agree with @cphyc! |
|
Any reason not to just merge once it passes? |
jzuhone
approved these changes
May 24, 2021
I don't see why not. |
IMO an inline comment linking to the upstream ticket is enough :) |
|
@Xarthisius if you're ok with it I'll commit the suggestion from @neutrinoceros and merge it. |
Co-authored-by: Clément Robert <[email protected]>
committed |
Why not both? |
This was referenced May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin proj library on osx until SciTools/cartopy#1140 is fixed.
PR Summary
Should fix failing OSX build.